Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a bunch of refactoring changes for 3.0.0 #212

Merged
merged 9 commits into from
Jan 19, 2020
Merged

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Oct 16, 2019

Apply a bunch of refactoring changes. These changes are for release in 3.0.0.

Changelog will follow.

Fixes #221
Closes #216

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Oct 16, 2019

4 Warnings
⚠️ Big PR, consider splitting into smaller
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L669 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L1359 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 669 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1359 Prefer empty collection over optional collection.

Generated by 🚫 Danger

@Zandor300 Zandor300 marked this pull request as ready for review November 6, 2019 15:47
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!! Thank you 😊!

@denisenepraunig denisenepraunig merged commit 7dec8f8 into master Jan 19, 2020
@Zandor300 Zandor300 deleted the refactoring branch August 11, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in comment Provide a sanitized or safe device description
3 participants