Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum deployment target iOS 9.0 and apply Xcode 12 recommended settings. #249

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Minimum deployment target iOS 9.0 and apply Xcode 12 recommended settings. #249

merged 3 commits into from
Aug 31, 2020

Conversation

Zandor300
Copy link
Member

This PR does 2 things:

  • Apply recommended settings for Xcode 12.
  • Change minimum deployment target from iOS 8.0 to iOS 9.0 since Xcode 12 dropped support for iOS 8.0.

tbaranes
tbaranes previously approved these changes Aug 11, 2020
View reviewed changes
@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Aug 11, 2020 •
edited
Loading

1 Warning
⚠️ Plist changed, don’t forget to localize your plist values

Generated by 🚫 Danger

denisenepraunig
denisenepraunig approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@denisenepraunig denisenepraunig merged commit 4b7f5f3 into master Aug 31, 2020
@kkdayitbobson
Copy link

PodSpec can't use master branch, can publish to new release? thanks

@Zandor300 Zandor300 deleted the xcode-12-settings branch September 4, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisenepraunig denisenepraunig denisenepraunig approved these changes

@tbaranes tbaranes tbaranes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zandor300 @devicekit-danger-bot @kkdayitbobson @tbaranes @denisenepraunig