Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in v4.2.0 release #268

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Fix bugs in v4.2.0 release #268

merged 5 commits into from
Oct 22, 2020

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Oct 22, 2020 •
edited
Loading

This pull request fixes a couple of bugs introduced in the v4.2.0 release:

  • Device.allDevicesWithALidarSensor didn't include iPhone 12 Pro and iPhone 12 Pro Max. (#268 #266)
  • Device.iPadAir4.screenRatio returned an invalid screen ratio. (#268 #267)

Fixes #267
Fixes #266

@Zandor300 Zandor300 marked this pull request as ready for review October 22, 2020 09:19
denisenepraunig
denisenepraunig previously approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zandor300 👍

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Oct 22, 2020 •
edited
Loading

13 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L151 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L153 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L155 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L157 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L159 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L161 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L163 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L165 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L207 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L209 - TODOs should be resolved ()).
⚠️ Source/Device.generated.swift#L760 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L1495 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 760 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1495 Prefer empty collection over optional collection.
Device.generated.swift 151 TODOs should be resolved ()).
Device.generated.swift 153 TODOs should be resolved ()).
Device.generated.swift 155 TODOs should be resolved ()).
Device.generated.swift 157 TODOs should be resolved ()).
Device.generated.swift 159 TODOs should be resolved ()).
Device.generated.swift 161 TODOs should be resolved ()).
Device.generated.swift 163 TODOs should be resolved ()).
Device.generated.swift 165 TODOs should be resolved ()).
Device.generated.swift 207 TODOs should be resolved ()).
Device.generated.swift 209 TODOs should be resolved ()).

Generated by 🚫 Danger

denisenepraunig
denisenepraunig approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😊

@denisenepraunig denisenepraunig merged commit dbddb02 into master Oct 22, 2020
@denisenepraunig denisenepraunig deleted the ipadair4-aspect-ratio-fix branch October 22, 2020 18:01
AbcTM added a commit to AbcTM/DeviceKit that referenced this pull request Feb 3, 2021
@AbcTM
Merge pull request #4 from devicekit/master
5d88f6b 
Fix bugs in v4.2.0 release (devicekit#268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisenepraunig denisenepraunig denisenepraunig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iPadAir4 screen ratio is not correct?? allDevicesWithALidarSensor wrong values
3 participants
@Zandor300 @devicekit-danger-bot @denisenepraunig