Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing technical specification and image urls. #272

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Nov 9, 2020

Following devices were missing technical specifications and image support urls:

  • iPhone 12
  • iPhone 12 mini
  • iPhone 12 Pro
  • iPhone 12 Pro Max
  • iPad Air (4th generation)

This PR also includes the version bump and changelog for the upcoming 4.3.0 release.

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Nov 9, 2020

3 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L760 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L1495 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 760 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1495 Prefer empty collection over optional collection.

Generated by 🚫 Danger

@Zandor300 Zandor300 marked this pull request as ready for review November 18, 2020 14:09
Kaspik
Kaspik previously approved these changes Feb 12, 2021
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zandor300 🎉

@denisenepraunig denisenepraunig merged commit 96387cc into master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants