Add support for new September 14th 2021 devices. #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the device support files in Xcode 13 RC these are the device identifiers:
Although not necessarily relevant for this PR the device identifiers for Apple Watch Series 7
This is probably an incomplete list of all actually available device identifiers. |
|
@insightmind Thanks! |
Because it will be available on the fall, we won't know device identifiers, so it doesn't make sense to add support yet.
Zandor300
force-pushed
the
new-september-14-2021-devices
branch
from
120fb6e to
45d40af
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -164,6 +164,22 @@ public enum Device { | |||
| /// | |||
| ///  | |||
| case iPhone12ProMax | |||
| /// Device is an [iPhone 13](https://support.apple.com/kb/TODO) | |||
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:167 |
| @@ -164,6 +164,22 @@ public enum Device { | |||
| /// | |||
| ///  | |||
| case iPhone12ProMax | |||
| /// Device is an [iPhone 13](https://support.apple.com/kb/TODO) | |||
| /// | |||
| ///  | |||
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:169 |
| /// | ||
| ///  | ||
| case iPhone13 | ||
| /// Device is an [iPhone 13 mini](https://support.apple.com/kb/TODO) |
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:171 |
| case iPhone13 | ||
| /// Device is an [iPhone 13 mini](https://support.apple.com/kb/TODO) | ||
| /// | ||
| ///  |
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:173 |
| /// | ||
| ///  | ||
| case iPhone13Mini | ||
| /// Device is an [iPhone 13 Pro](https://support.apple.com/kb/TODO) |
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:175 |
| case iPhone13Mini | ||
| /// Device is an [iPhone 13 Pro](https://support.apple.com/kb/TODO) | ||
| /// | ||
| ///  |
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:177 |
| /// | ||
| ///  | ||
| case iPhone13Pro | ||
| /// Device is an [iPhone 13 Pro Max](https://support.apple.com/kb/TODO) |
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:179 |
| case iPhone13Pro | ||
| /// Device is an [iPhone 13 Pro Max](https://support.apple.com/kb/TODO) | ||
| /// | ||
| ///  |
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:181 |
| @@ -204,6 +220,10 @@ public enum Device { | |||
| /// | |||
| ///  | |||
| case iPad8 | |||
| /// Device is an [iPad (9th generation)](https://support.apple.com/kb/TODO) | |||
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:223 |
| @@ -204,6 +220,10 @@ public enum Device { | |||
| /// | |||
| ///  | |||
| case iPad8 | |||
| /// Device is an [iPad (9th generation)](https://support.apple.com/kb/TODO) | |||
| /// | |||
| ///  | |||
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:225 |
| @@ -228,6 +248,10 @@ public enum Device { | |||
| /// | |||
| ///  | |||
| case iPadMini5 | |||
| /// Device is an [iPad Mini (6th generation)](https://support.apple.com/kb/TODO) | |||
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:251 |
| @@ -228,6 +248,10 @@ public enum Device { | |||
| /// | |||
| ///  | |||
| case iPadMini5 | |||
| /// Device is an [iPad Mini (6th generation)](https://support.apple.com/kb/TODO) | |||
| /// | |||
| ///  | |||
There was a problem hiding this comment.
TODOs should be resolved ()).todo Device.generated.swift:253 |
| @@ -680,33 +722,33 @@ public enum Device { | |||
|
|
|||
| /// All iPhones | |||
| public static var allPhones: [Device] { | |||
| return [.iPhone4, .iPhone4s, .iPhone5, .iPhone5c, .iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax] | |||
| return [.iPhone4, .iPhone4s, .iPhone5, .iPhone5c, .iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:725 |
| } | ||
|
|
||
| /// All iPads | ||
| public static var allPads: [Device] { | ||
| return [.iPad2, .iPad3, .iPad4, .iPadAir, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPadAir4, .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | ||
| return [.iPad2, .iPad3, .iPad4, .iPadAir, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPad9, .iPadAir4, .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadMini6, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:730 |
| } | ||
|
|
||
| /// All X-Series Devices | ||
| @available(*, deprecated, renamed: "allDevicesWithSensorHousing") | ||
| public static var allXSeriesDevices: [Device] { | ||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax] | ||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:736 |
| } | ||
|
|
||
| /// All Plus and Max-Sized Devices | ||
| public static var allPlusSizedDevices: [Device] { | ||
| return [.iPhone6Plus, .iPhone6sPlus, .iPhone7Plus, .iPhone8Plus, .iPhoneXSMax, .iPhone11ProMax, .iPhone12ProMax] | ||
| return [.iPhone6Plus, .iPhone6sPlus, .iPhone7Plus, .iPhone8Plus, .iPhoneXSMax, .iPhone11ProMax, .iPhone12ProMax, .iPhone13ProMax] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:741 |
| } | ||
|
|
||
| /// All Pro Devices | ||
| public static var allProDevices: [Device] { | ||
| return [.iPhone11Pro, .iPhone11ProMax, .iPhone12Pro, .iPhone12ProMax, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | ||
| return [.iPhone11Pro, .iPhone11ProMax, .iPhone12Pro, .iPhone12ProMax, .iPhone13Pro, .iPhone13ProMax, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:746 |
| } | ||
|
|
||
| /// All mini Devices | ||
| public static var allMiniDevices: [Device] { | ||
| return [.iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5] | ||
| return [.iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadMini6] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:751 |
There was a problem hiding this comment.
Just wondering in the future if the iPhone Minis (12 and 13) are also mini devices. 🤔
| @@ -788,17 +830,17 @@ public enum Device { | |||
|
|
|||
| /// All Touch ID Capable Devices | |||
| public static var allTouchIDCapableDevices: [Device] { | |||
| return [.iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneSE2, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPadAir4, .iPadMini3, .iPadMini4, .iPadMini5, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch] | |||
| return [.iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneSE2, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPad9, .iPadAir4, .iPadMini3, .iPadMini4, .iPadMini5, .iPadMini6, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:833 |
| } | ||
|
|
||
| /// All Face ID Capable Devices | ||
| public static var allFaceIDCapableDevices: [Device] { | ||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | ||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:838 |
| } | ||
|
|
||
| /// All Devices with Touch ID or Face ID | ||
| public static var allBiometricAuthenticationCapableDevices: [Device] { | ||
| return [.iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPadAir4, .iPadMini3, .iPadMini4, .iPadMini5, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | ||
| return [.iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPad9, .iPadAir4, .iPadMini3, .iPadMini4, .iPadMini5, .iPadMini6, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:843 |
| @@ -818,7 +860,7 @@ public enum Device { | |||
|
|
|||
| /// All devices that feature a sensor housing in the screen | |||
| public static var allDevicesWithSensorHousing: [Device] { | |||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax] | |||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:863 |
| @@ -833,7 +875,7 @@ public enum Device { | |||
|
|
|||
| /// All devices that feature a screen with rounded corners. | |||
| public static var allDevicesWithRoundedDisplayCorners: [Device] { | |||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPadAir4, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
| return [.iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPadAir4, .iPadMini6, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:878 |
| @@ -853,7 +895,7 @@ public enum Device { | |||
|
|
|||
| /// All devices that support wireless charging. | |||
| public static var allDevicesWithWirelessChargingSupport: [Device] { | |||
| return [.iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax] | |||
| return [.iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:898 |
| @@ -863,7 +905,7 @@ public enum Device { | |||
|
|
|||
| /// All devices that have a LiDAR sensor. | |||
| public static var allDevicesWithALidarSensor: [Device] { | |||
| return [.iPhone12Pro, .iPhone12ProMax, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
| return [.iPhone12Pro, .iPhone12ProMax, .iPhone13Pro, .iPhone13ProMax, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:908 |
| @@ -1565,7 +1625,7 @@ extension Device { | |||
|
|
|||
| /// All Apple Pencil Capable Devices | |||
| public static var allApplePencilCapableDevices: [Device] { | |||
| return [.iPad6, .iPadAir3, .iPad7, .iPad8, .iPadAir4, .iPadMini5, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
| return [.iPad6, .iPadAir3, .iPad7, .iPad8, .iPad9, .iPadAir4, .iPadMini5, .iPadMini6, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1628 |
| default: return [] | ||
| } | ||
| } | ||
|
|
||
| /// All devices that feature a camera | ||
| public static var allDevicesWithCamera: [Device] { | ||
| return [.iPodTouch5, .iPodTouch6, .iPodTouch7, .iPhone4, .iPhone4s, .iPhone5, .iPhone5c, .iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPad2, .iPad3, .iPad4, .iPadAir, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPadAir4, .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | ||
| return [.iPodTouch5, .iPodTouch6, .iPodTouch7, .iPhone4, .iPhone4s, .iPhone5, .iPhone5c, .iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPad2, .iPad3, .iPad4, .iPadAir, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPad9, .iPadAir4, .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadMini6, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1742 |
| @@ -1682,17 +1750,17 @@ extension Device { | |||
|
|
|||
| /// All devices that feature a wide camera | |||
| public static var allDevicesWithWideCamera: [Device] { | |||
| return [.iPodTouch5, .iPodTouch6, .iPodTouch7, .iPhone4, .iPhone4s, .iPhone5, .iPhone5c, .iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPad2, .iPad3, .iPad4, .iPadAir, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPadAir4, .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
| return [.iPodTouch5, .iPodTouch6, .iPodTouch7, .iPhone4, .iPhone4s, .iPhone5, .iPhone5c, .iPhone5s, .iPhone6, .iPhone6Plus, .iPhone6s, .iPhone6sPlus, .iPhone7, .iPhone7Plus, .iPhoneSE, .iPhone8, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhoneXR, .iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhoneSE2, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPad2, .iPad3, .iPad4, .iPadAir, .iPadAir2, .iPad5, .iPad6, .iPadAir3, .iPad7, .iPad8, .iPad9, .iPadAir4, .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5, .iPadMini6, .iPadPro9Inch, .iPadPro12Inch, .iPadPro12Inch2, .iPadPro10Inch, .iPadPro11Inch, .iPadPro12Inch3, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | |||
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1753 |
| } | ||
|
|
||
| /// All devices that feature a telephoto camera | ||
| public static var allDevicesWithTelephotoCamera: [Device] { | ||
| return [.iPhone7Plus, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhone11Pro, .iPhone11ProMax, .iPhone12Pro, .iPhone12ProMax] | ||
| return [.iPhone7Plus, .iPhone8Plus, .iPhoneX, .iPhoneXS, .iPhoneXSMax, .iPhone11Pro, .iPhone11ProMax, .iPhone12Pro, .iPhone12ProMax, .iPhone13Pro, .iPhone13ProMax] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1758 |
| } | ||
|
|
||
| /// All devices that feature an ultra wide camera | ||
| public static var allDevicesWithUltraWideCamera: [Device] { | ||
| return [.iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] | ||
| return [.iPhone11, .iPhone11Pro, .iPhone11ProMax, .iPhone12, .iPhone12Mini, .iPhone12Pro, .iPhone12ProMax, .iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPadPro11Inch2, .iPadPro12Inch4, .iPadPro11Inch3, .iPadPro12Inch5] |
There was a problem hiding this comment.
Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1763 |
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
denisenepraunig
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Nice work - thank you @Zandor300 and @insightmind for the identifiers!
I will merge it with the device identifiers - the images and support articles take some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required
Optional