Skip to content

schemas: pci: bridge: Document WAKE# interrupt properties #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mani-Sadhasivam wants to merge 1 commit into from
Closed

schemas: pci: bridge: Document WAKE# interrupt properties #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dtschema/schemas/pci/pci-pci-bridge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,10 @@ properties:
to D3 states.
type: boolean

interrupts:
description: wakeup interrupt

interrupt-names:
const: wake

Copy link
Member

@robherring robherring May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent that the only interrupt is wake? Because 'const: wake' implies 1 entry only. Also, I think we should stick with the common name "wakeup" used elsewhere.

I think this belongs in pci-device.yaml. Couldn't we have a single endpoint device with WAKE going to a GPIO as well?

Note that 'interrupts-extended' is now explicitly supported in pci-device.yaml to support some other cases of sideband interrupts (e.g. Marvell 370 RPs).

Copy link

@SherrySun5 SherrySun5 May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is a recent patch set trying to add pcie wake support (https://lore.kernel.org/linux-pci/20250419-wake_irq_support-v2-0-06baed9a87a1@oss.qualcomm.com/).
Not sure if the corresponding wake-gpios property should be added into the pci-pci-bridge.yaml.

Copy link
Author

@Mani-Sadhasivam Mani-Sadhasivam May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent that the only interrupt is wake? Because 'const: wake' implies 1 entry only. Also, I think we should stick with the common name "wakeup" used elsewhere.

I think this belongs in pci-device.yaml. Couldn't we have a single endpoint device with WAKE going to a GPIO as well?

Note that 'interrupts-extended' is now explicitly supported in pci-device.yaml to support some other cases of sideband interrupts (e.g. Marvell 370 RPs).

Maybe we should just stick to 'wake-gpios' property and get the irq info from it to use as the wakeup interrupt? But anyway, a Qcom developer is now working on it and he has submitted a patch to the devicetree list for adding the property to the schema. So I'm closing this PR.

unevaluatedProperties: false