Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: solidjs (original, original-wordmark, plain, plain-wordmark) #1557

Merged
merged 11 commits into from
Jan 30, 2023
Merged

new icon: solidjs (original, original-wordmark, plain, plain-wordmark) #1557

merged 11 commits into from
Jan 30, 2023

Conversation

AbdelrahmanDwedar
Copy link
Contributor

@AbdelrahmanDwedar AbdelrahmanDwedar commented Nov 27, 2022 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1253

Link to prove your SVG is correct and up-to-date.

https://www.solidjs.com/media

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 28, 2022
Snailedlt
Snailedlt requested changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wordmark icons aren't centered and resized correctly. Look at the file previews

@lunatic-fox
Copy link
Contributor

This PR closes #1253 (staled PR)

@AbdelrahmanDwedar
Copy link
Contributor Author

Oh I didn't see it. Sorry.

@AbdelrahmanDwedar
Copy link
Contributor Author

Wordmark icons aren't centered and resized correctly. Look at the file previews

I'll check them out, maybe I forgot to do something.

@AbdelrahmanDwedar
Copy link
Contributor Author

I don't know what happened in the plain wordmark version the colors seem to disappear in the image.

@lunatic-fox
Copy link
Contributor

Oh I didn't see it. Sorry.

No problem! 🙂

lunatic-fox
lunatic-fox requested changes Dec 3, 2022
View reviewed changes
icons/solidjs/solidjs-original-wordmark.svg Outdated Show resolved Hide resolved
icons/solidjs/solidjs-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/solidjs/solidjs-original.svg Outdated Show resolved Hide resolved
icons/solidjs/solidjs-plain.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 17, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox
lunatic-fox previously approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are ok now and conflicts are resolved in devicon.json
Thank you for this contribution! 🚀

Snailedlt
Snailedlt requested changes Dec 17, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
icons/solidjs/solidjs-original-wordmark.svg Outdated Show resolved Hide resolved
lunatic-fox and others added 2 commits December 17, 2022 13:04
@lunatic-fox @Snailedlt
Update devicon.json
24e61b3 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@lunatic-fox
Update original and original-wordmark versions
e618910
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you for your contribution! ✔️

@Snailedlt Snailedlt merged commit 1a17d57 into devicons:develop Jan 30, 2023
@Snailedlt Snailedlt mentioned this pull request Jan 30, 2023
Closed
1 task
@canaleal canaleal mentioned this pull request Oct 23, 2023
Closed
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@AbdelrahmanDwedar @lunatic-fox @Snailedlt
new icon: solidjs (original, original-wordmark, plain, plain-wordmark) (
62b050d 
devicons#1557)

* Add solidjs icons (original, original-wordmark, plain, plain-wordmark)

* Add solidjs to the devicon.json

* Fix: resize & center the wordmarks

* Update icons/solidjs/solidjs-original-wordmark.svg

* Update icons/solidjs/solidjs-plain-wordmark.svg

* Update devicon.json

* Align and optimize icons

* Update devicon.json

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update `original` and `original-wordmark` versions

---------

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Co-authored-by: unknown <joseliojrx25@gmail.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbdelrahmanDwedar @lunatic-fox @Snailedlt