-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Icon: Forgejo (Original) #1926
Conversation
Hey, Maintainer Please Review This PR !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched a bit, and only found the wordmark version of the Logo https://codeberg.org/forgejo/pages/src/branch/main/images/forgejo-wordmark.svg
Can you add the wordmark version too?
Also i think we need the plain version to be used for the font.
So in the end original
, original-wordmark
, plain
, plain-wordmark
how should I convert the original to plain? @weh |
I prefer to use Inkscape for this. Followed by
That is my preferred workflow. You can find the Links here: https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools |
Hey @Yashh56 , sorry for the super long comment, but here's the workflow I follow to create new Icons. Resize the SVG and Align Horizontally/ Vertically (Inkscape)
Unify the Paths and create Plain Icons (Inkscape)Shout out to @yeyeto2788 and @lunatic-fox for these steps.
Why Optimize the SVG (Inkscape)
Optimizing the SVG using SVGOMGShout out to @BenSouchet, all the steps I used were from this comment
|
Hey @canaleal Are these changes correct? |
Hey @Yashh56, I took a look at the Icon and I see what the problem is. The strokes can be converted into paths by selecting all elements on the page You can still follow the workflow I posted above to optimize, resize, and make plain SVGs. Original SVG WordmarkHere, I cleaned up the original SVG and converted it to object paths. This can be used to create the plain icons.
|
I will make this changes ASAP @canaleal Thanks for the help |
Hey @canaleal Are these changes correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some things to fix here
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path d="M19.74 0c-1.644 0-3.092 2.504-3.87 6.198h-1.853C7.54 6.198 2.24 20.865 2.24 38.794v47.373C.906 88.324 0 92.322 0 96.87c0 6.802 2.021 12.396 4.479 12.396s4.479-5.594 4.479-12.396c0-4.548-.906-8.546-2.24-10.703V73.112c0-11.23 3.242-20.2 7.3-20.2h1.855c.78 3.69 2.224 6.197 3.868 6.197 2.458 0 4.479-5.593 4.479-12.396 0-6.802-2.021-12.395-4.48-12.395-1.643 0-3.087 2.507-3.867 6.198h-1.856c-2.751 0-5.288 2.653-7.299 7.07v-8.792c0-11.23 3.242-20.2 7.3-20.2h1.851c.78 3.693 2.227 6.197 3.872 6.197 2.458 0 4.479-5.593 4.479-12.395C24.22 5.593 22.199 0 19.74 0Zm0 7.346c1.024 0 1.825 2.217 1.825 5.05 0 2.832-.8 5.05-1.824 5.05s-1.825-2.218-1.825-5.05c0-2.833.801-5.05 1.825-5.05zm83.25 28.28c-2.198 0-4.005 5.002-4.005 11.087 0 6.086 1.807 11.088 4.006 11.088 2.199 0 4.006-5.002 4.006-11.088 0-6.085-1.807-11.087-4.006-11.087zm-83.25 6.037c1.024 0 1.825 2.218 1.825 5.05 0 2.833-.8 5.05-1.824 5.05s-1.825-2.217-1.825-5.05c0-2.832.801-5.05 1.825-5.05zm83.25.299c.963 0 1.718 2.09 1.718 4.751 0 2.662-.755 4.752-1.717 4.752-.962 0-1.717-2.09-1.717-4.752 0-2.661.755-4.751 1.717-4.751zm-47.412 9.863c-1.93 0-3.547 1.076-4.85 3.227-1.102 1.758-1.918 4.225-2.482 7.32V52.346h-3.009v54.945h3.159v-27.68c0-6.244.576-11.03 1.73-14.36 1.153-3.4 2.72-5.1 4.7-5.1a.77.77 0 0 1 .376.104c.125 0 .25.035.376.104zm10.657 0c-1.905 0-3.622 1.11-5.152 3.33-1.504 2.22-2.694 5.342-3.571 9.366-.878 3.955-1.317 8.569-1.317 13.842 0 5.272.44 9.92 1.317 13.944.877 4.023 2.067 7.18 3.571 9.47 1.53 2.22 3.247 3.329 5.152 3.329 1.73 0 3.284-1.006 4.662-3.017.85-1.219 1.582-2.838 2.22-4.768l-.1 3.83c-.172 6.504-.577 11.343-1.73 14.465-1.153 3.192-2.946 4.787-5.377 4.787-1.48 0-2.908-.659-4.287-1.977-1.353-1.318-2.494-3.122-3.421-5.411l-1.58 6.764c1.078 2.636 2.457 4.648 4.136 6.036 1.705 1.456 3.46 2.185 5.264 2.185 3.335 0 5.854-2.255 7.558-6.765 1.705-4.44 2.557-11.446 2.557-21.02 0-13.195.625-29.42-1.23-36.526-.827-3.954-1.942-6.903-3.346-8.845-1.379-2.012-3.596-3.019-5.326-3.019zm-33.858.001c-1.98 0-3.735 1.215-5.264 3.643-1.529 2.358-2.745 5.654-3.647 9.885-.878 4.163-1.316 8.984-1.316 14.465 0 5.411.438 10.233 1.316 14.465.902 4.232 2.118 7.562 3.647 9.99 1.554 2.358 3.309 3.537 5.264 3.537s3.698-1.179 5.227-3.537c1.554-2.428 2.77-5.758 3.647-9.99.877-4.232 1.316-9.054 1.316-14.465 0-5.48-.439-10.302-1.316-14.465-.877-4.231-2.093-7.527-3.647-9.885-1.53-2.428-3.272-3.643-5.227-3.643zm85.433 0c-1.98 0-3.735 1.215-5.264 3.643-1.53 2.358-2.745 5.654-3.647 9.885-.878 4.163-1.316 8.984-1.316 14.465 0 5.411.438 10.233 1.316 14.465.902 4.232 2.118 7.562 3.647 9.99 1.554 2.358 3.309 3.537 5.264 3.537s3.698-1.179 5.227-3.537c1.554-2.428 2.77-5.758 3.647-9.99.877-4.232 1.316-9.054 1.316-14.465 0-5.48-.439-10.302-1.316-14.465-.877-4.231-2.093-7.527-3.647-9.885-1.53-2.428-3.272-3.643-5.227-3.643zm-28.91.121c-1.905 0-3.61 1.214-5.113 3.642-1.48 2.359-2.645 5.655-3.497 9.887-.853 4.231-1.279 9.053-1.279 14.464s.439 10.232 1.316 14.464c.903 4.232 2.143 7.562 3.723 9.99 1.604 2.359 3.447 3.538 5.527 3.538 1.63 0 3.108-.763 4.437-2.289 1.328-1.526 2.419-3.746 3.271-6.66l-1.73-5.619c-.726 2.359-1.591 4.127-2.594 5.307-1.003 1.11-2.106 1.665-3.309 1.665-1.504 0-2.832-.833-3.986-2.498-1.128-1.734-2.017-4.162-2.669-7.284a45.141 45.141 0 0 1-.495-3.255l16.062-8.712c-.05-5.342-.514-9.99-1.391-13.945-.853-4.023-1.993-7.145-3.422-9.365-1.429-2.22-3.046-3.33-4.85-3.33Zm0 7.492c1.304 0 2.457.833 3.46 2.498 1.002 1.596 1.78 3.78 2.33 6.556.353 1.694.584 3.534.721 5.487L82.09 81.098c-.012-.558-.032-1.101-.032-1.678 0-4.024.288-7.528.864-10.511.577-2.983 1.38-5.307 2.407-6.972 1.053-1.665 2.244-2.498 3.572-2.498zm-56.523.088c1.354 0 2.557.832 3.61 2.497s1.88 4.023 2.482 7.076c.626 3.053.94 6.626.94 10.719 0 4.024-.314 7.597-.94 10.719-.602 3.052-1.43 5.445-2.482 7.18-1.053 1.664-2.256 2.498-3.61 2.498s-2.557-.834-3.61-2.499c-1.052-1.734-1.892-4.127-2.519-7.18-.601-3.121-.902-6.694-.902-10.718 0-4.093.3-7.666.902-10.72.627-3.052 1.467-5.41 2.52-7.075 1.052-1.665 2.255-2.497 3.61-2.497zm33.827 0c1.404 0 2.645.798 3.723 2.393 1.077 1.527 1.917 3.712 2.519 6.556.626 2.844.94 6.14.94 9.887 0 3.746-.314 7.076-.94 9.99-.602 2.844-1.441 5.064-2.52 6.66-1.077 1.595-2.318 2.392-3.722 2.392-1.379 0-2.607-.797-3.685-2.393-1.078-1.596-1.93-3.815-2.557-6.66-.602-2.913-.902-6.243-.902-9.99 0-3.746.3-7.042.902-9.886.627-2.844 1.48-5.03 2.557-6.556 1.078-1.595 2.306-2.393 3.685-2.393zm51.606 0c1.354 0 2.557.832 3.61 2.497s1.88 4.023 2.481 7.076c.627 3.053.94 6.626.94 10.719 0 4.024-.313 7.597-.94 10.719-.601 3.052-1.429 5.445-2.481 7.18-1.053 1.664-2.256 2.498-3.61 2.498s-2.557-.834-3.61-2.499c-1.053-1.734-1.892-4.127-2.519-7.18-.601-3.121-.902-6.694-.902-10.718 0-4.093.3-7.666.902-10.72.627-3.052 1.466-5.41 2.52-7.075 1.052-1.665 2.255-2.497 3.609-2.497zm-16.222 2.001v49.093c0 3.33-.276 5.828-.827 7.493-.527 1.665-1.291 2.497-2.294 2.497-1.228 0-2.23-.866-3.008-2.6l-1.053 6.555c.501 1.18 1.128 2.046 1.88 2.601.752.555 1.542.833 2.369.833 1.955 0 3.46-1.56 4.512-4.682 1.053-3.122 1.58-7.354 1.58-12.697V61.528ZM4.479 91.82c1.023 0 1.825 2.217 1.825 5.05 0 2.833-.802 5.05-1.825 5.05-1.024 0-1.825-2.217-1.825-5.05 0-2.833.801-5.05 1.825-5.05z"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed all the instructions @weh
icons/forgejo/forgejo-plain.svg
Outdated
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><g fill="#f9f9f9" stroke="#000"><path stroke-width="15.166" d="M37.261 105.534v-59.45c0-16.754 13.581-30.33 30.33-30.33h12.133"/><path stroke-width="15.166" d="M37.261 105.534V87.332c0-16.75 13.581-30.33 30.33-30.33h12.133"/><path stroke-width="9.099" d="M99.136 15.754c0 6.028-4.886 10.918-10.918 10.918-6.029 0-10.918-4.89-10.918-10.918 0-6.033 4.89-10.922 10.918-10.922 6.032 0 10.918 4.89 10.918 10.922zm0 41.248c0 6.033-4.886 10.918-10.918 10.918-6.029 0-10.918-4.885-10.918-10.918 0-6.028 4.89-10.918 10.918-10.918 6.032 0 10.918 4.89 10.918 10.918zM48.18 112.81c0 6.033-4.89 10.922-10.919 10.922-6.032 0-10.918-4.89-10.918-10.922 0-6.028 4.886-10.918 10.918-10.918 6.029 0 10.918 4.89 10.918 10.918zm0 0"/></g></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
Hey, Maintainer Please Review This PR !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let me help you a bit with the images here.
Next time try to fix what the reviewers tell you. Don't worry if you need a bit of time and maybe also need to learn Inkscape. Don't rush and ask for multiple reviews, if you can see with your own eyes, that the images look wrong.
I guess i should also take some time and try to add some more hints, on how to fix specific things, when editing SVG images.
Thank you for your contribution, and happy hacktoberfest :)
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
thank you for the help @weh |
Wow great tutorial here @canaleal! Would you mind adding the thing with objects, and adding it to this issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Just some small suggestions for devicon.json
"plain-wordmark" | ||
], | ||
"font": [ | ||
"original" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little whoopsie that needs to be fixed ;)
"original" | |
"plain", | |
"plain-wordmark" |
"name": "forgejo", | ||
"altnames": [], | ||
"tags": [ | ||
"software" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"software" | |
"software", | |
"git", | |
"version-control" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we have to do some little adjustments here. 🔧
- All icons need to have one line with the SVG code and another with the newline character, but the files have 3 lines instead. If you're using some code editor, please take a look if you have just 2 lines or if when you trying to remove the third line it inserts a newline automatically - if that is the case, remove any newlines until the SVG code and wait for the code editor autocomplete it.
#000000
is the only fill color that can be omitted in most cases.
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Optimizing is a 1 Click task with SVGVIEWERI found it more easier to do with it.
BOOM !!! The SVG is optimized, without ruining the viewbox. |
(Hacktobeberfest PR)
PR name matches the format new icon: Icon name (versions separated by a comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here
This PR closes #1902
Link to prove your SVG is correct and up-to-date.
https://codeberg.org/forgejo/governance/media/branch/main/branding/logo/forgejo.svg