Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: chartjs (original, original-wordmark, plain, plain-wordmark) #2003

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

weh
Copy link
Contributor

@weh weh commented Nov 13, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes

closes #1822

Link to prove your SVG is correct and up-to-date.

https://www.chartjs.org/

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 13, 2023 16:57
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 18, 2023
canaleal
canaleal previously approved these changes Jan 14, 2024
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the contribution.
Just optimized and combined the plain svg paths.

@weh weh force-pushed the feature/1822-chartjs-icon branch 2 times, most recently from 2d27cf6 to 178f8ad Compare January 15, 2024 15:54
@weh
Copy link
Contributor Author

weh commented Jan 15, 2024

optimized with correct svgomg options this time, and rebased to current develop branch

@weh weh requested a review from canaleal January 15, 2024 15:59
canaleal
canaleal previously approved these changes Jan 17, 2024
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. LGTM

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



SVG Error in 'chartjs-plain.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

SVG Error in 'chartjs-plain-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@canaleal canaleal merged commit 259acf8 into devicons:develop Dec 7, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: chartjs (original, original-wordmark, plain, plain-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants