-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: firebase (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great PR! However I'm not sure that yellow is the right color choice. I feel like the middle orange color (#ffa712
) should be chosen instead.
Anecdotally I've found that orange is more commonly used on their website, it's also what I associate with firebase. Another good reason to pick that color imo is that it's a middle-point between the yellow (#ffcc2e
) and dark orange (#f6830e
) color, and it's more easily visible on white backgrounds, while also being bright enough for dark backgrounds.
Would love a 2nd and 3rd opinion on this though, which is why this is a "comment" and not a "request changes" review. @lunatic-fox @canaleal @weh what do you guys think?
Honestly, I was little hesitant on choosing yellow for those exact same reasons (Hard to see, prominent on the logo but not the most common color on the website). I think the dark orange is a bit too much, but the middle orange |
I didn't take a close look at the website, but from just a quick look, it looked like there were multiple different shades of yellow/orange being used. Sidenote: Another reason is that the dark orange seems to be the "shadow color", and the yellow seems to be the "highlight color". By that logic the light orange color would be the "base color". |
I like the Here are the official colors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color needs to be changed to #ffa000
, which is Firebase Amber (ref)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇♂️
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
The yellow color
#ffcc2e
was used for the font SVGs and is can be found on the bottom shape of the original svg.