-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: angular (original, original-wordmark, plain, plain-wordmark) #2085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a pretty good PR, it's a good start for sure!
The plain icons look good and are just missing optimization, while the original versions need to be changed to pure SVG versions. See my suggestions for more info
I optimized the plain icons with the tool you sent, but the originals are a bit more complex. They use a freeform gradient, which svg doesn't support (only supports linearGradient and radialGradient), so that's why illustrator rasterizes it. I've been looking into this, but I'm not sure there's any way around it |
Should be all good now? I removed the data-name as requested and also optimized and uploaded the originals, let me know if anything else needs fixing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when does this get merged? |
@derBinder when it has 1 more accepted review and after the next release: #2105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
update icon: angular (original, original-wordmark, plain, plain-wordmark)
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1988
Link to prove your SVG is correct and up-to-date.
https://angular.dev/press-kit