Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: angular (original, original-wordmark, plain, plain-wordmark) #2085

Merged
merged 4 commits into from
Apr 14, 2024
Merged

update icon: angular (original, original-wordmark, plain, plain-wordmark) #2085

merged 4 commits into from
Apr 14, 2024

Conversation

gabrielfins
Copy link
Contributor

@gabrielfins gabrielfins commented Dec 4, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1988

Link to prove your SVG is correct and up-to-date.

https://angular.dev/press-kit

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 4, 2023
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team December 4, 2023 17:45
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a pretty good PR, it's a good start for sure!
The plain icons look good and are just missing optimization, while the original versions need to be changed to pure SVG versions. See my suggestions for more info

icons/angular/angular-original-wordmark.svg Outdated Show resolved Hide resolved
icons/angular/angular-original.svg Outdated Show resolved Hide resolved
icons/angular/angular-plain-wordmark.svg Show resolved Hide resolved
icons/angular/angular-plain.svg Show resolved Hide resolved
@gabrielfins
Copy link
Contributor Author

I optimized the plain icons with the tool you sent, but the originals are a bit more complex. They use a freeform gradient, which svg doesn't support (only supports linearGradient and radialGradient), so that's why illustrator rasterizes it. I've been looking into this, but I'm not sure there's any way around it

@gabrielfins
Copy link
Contributor Author

Should be all good now? I removed the data-name as requested and also optimized and uploaded the originals, let me know if anything else needs fixing

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Great work on the PR! Loved the fast iterative improvements! 💯

image
image
image

@derBinder
Copy link

So when does this get merged?

@Snailedlt
Copy link
Collaborator

So when does this get merged?

@derBinder when it has 1 more accepted review and after the next release: #2105

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 2dab95d into devicons:develop Apr 14, 2024
5 checks passed
@gabrielfins gabrielfins deleted the develop branch April 14, 2024 17:15
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
update icon: angular (original, original-wordmark, plain, plain-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants