Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: teleport (original, original-wordmark, line, line-wordmark, plain, plain-wordmark) #2135

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

weh
Copy link
Contributor

@weh weh commented Feb 7, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

**This PR closes #1975 **

Link to prove your SVG is correct and up-to-date.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team February 7, 2024 12:27
@weh
Copy link
Contributor Author

weh commented Feb 7, 2024

the check-bot is not wrong, i guess there are json objects, not in alphabetical order. But not introduced in this PR.

  • tauri
  • teleport
  • tensorflow

but this reminds me of a idea i had, that may need some more discussion --> #2136

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Feb 17, 2024
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. No artifacts in any of the icons and they all look great.

image

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 6785773 into devicons:develop Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants