Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: raspberrypi (original, original-wordmark, plain, plain-wordmark) #221

Closed
wants to merge 6 commits into from

Conversation

Kartstig
Copy link
Contributor

@Kartstig Kartstig commented Jun 8, 2020

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
@amacado amacado self-requested a review June 11, 2020 19:45
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • At least the plain or line version of the icon is required (since those are required for the icon font)
  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

See #108 where plain version of pi icon was already added.

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Kartstig
Copy link
Contributor Author

Kartstig commented Jan 6, 2021

@amacado what would you like to do with this PR?

@amacado
Copy link
Member

amacado commented Jan 6, 2021

@Kartstig thanks for picking up! Feel free to update this pull request and fulfill our contribution guidelines. Once done we can review, merge and ship it with the next release! :)

@Kartstig
Copy link
Contributor Author

Kartstig commented Jan 7, 2021

@amacado This should be good to go now (I think)

@Kartstig Kartstig changed the base branch from master to develop January 7, 2021 15:22
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing a font version for this icon. At least one valid font version is required according to our guidelines.

@Kartstig Kartstig requested a review from amacado January 8, 2021 16:41
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed stale For PRs that haven't had any activity for a while and old issues labels Jan 8, 2021
@amacado amacado changed the title Add rpi icon new icon: raspberrypi (original, original-wordmark, plain, plain-wordmark) Jan 9, 2021
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 9, 2021
Comment on lines +13 to +15
width="3080.5601"
height="825.76001"
viewBox="0 0 3080.5601 825.76001"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at our guidelines regarding svg requirements. The when you update this pull request, those requirements should be checked by out bot.. Let's see :)

@amacado amacado added the stale For PRs that haven't had any activity for a while and old issues label Feb 23, 2021
@amacado amacado linked an issue May 2, 2021 that may be closed by this pull request
@Thomas-Boi
Copy link
Member

Hey @Kartstig,

Are you still planning to work on this? If not, I can take over and handle the rest.

@Kartstig
Copy link
Contributor Author

@Thomas-Boi if you can pick this up, that would be great!

@Thomas-Boi
Copy link
Member

@Thomas-Boi if you can pick this up, that would be great!

No problem 👍. I'll handle this and the other PR then

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels May 16, 2021
@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/raspberrypi/raspberrypi-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/raspberrypi/raspberrypi-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/raspberrypi/raspberrypi-plain-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/raspberrypi/raspberrypi-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/raspberrypi/raspberrypi-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/raspberrypi/raspberrypi-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue.

Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience.

Cheers,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Hey @Kartstig, I'll be closing this PR. Don't worry, the icon is still being accepted at #609. Thank you for your work 😄

@Thomas-Boi Thomas-Boi closed this May 16, 2021
@Thomas-Boi Thomas-Boi removed a link to an issue Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants