-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: raspberrypi (original, original-wordmark, plain, plain-wordmark) #221
Conversation
Kartstig
commented
Jun 8, 2020
- Adds Raspberry Pi icon
- From Add various new platforms and languages (elixir, phoenix, arduino, minix, raspberry pi) #102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:
- At least the plain or line version of the icon is required (since those are required for the icon font)
- Modify devicon.json to include the icon (or variations)
- Modify devicon-colors.css to include the colored version of the icon
See #108 where plain
version of pi icon was already added.
Hello there,
Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before. We hope to see your icons in the Devicon repo soon :) Cheers, |
Hello there, We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves. Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes. Cheers, |
@amacado what would you like to do with this PR? |
@Kartstig thanks for picking up! Feel free to update this pull request and fulfill our contribution guidelines. Once done we can review, merge and ship it with the next release! :) |
@amacado This should be good to go now (I think) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing a font
version for this icon. At least one valid font version is required according to our guidelines.
width="3080.5601" | ||
height="825.76001" | ||
viewBox="0 0 3080.5601 825.76001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at our guidelines regarding svg requirements. The when you update this pull request, those requirements should be checked by out bot.. Let's see :)
Hey @Kartstig, Are you still planning to work on this? If not, I can take over and handle the rest. |
@Thomas-Boi if you can pick this up, that would be great! |
No problem 👍. I'll handle this and the other PR then |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue. Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience. Cheers, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |