Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: laminas (original, original-wordmark, line, line-wordmark) #2246

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

hammad-521
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2234

Link to prove your SVG is correct and up-to-date.

https://getlaminas.org/

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 14, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team August 14, 2024 06:49
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall excellent work, just a few minor comments that have to be resolved.

icons/laminas/laminas-line.svg Outdated Show resolved Hide resolved
icons/laminas/laminas-line-wordmark.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@hammad-521
Copy link
Author

@canaleal
Thank you for your thorough review. I've addressed all the points you raised:

  1. icons/laminas/laminas-line.svg:

    • Scaled the SVG to 128 to reach the edges of the viewbox.
  2. icons/laminas/laminas-line-wordmark.svg:

    • Converted all strokes to paths.
  3. devicon.json:

    • Added 'original-wordmark', 'line', and 'line-wordmark' to the font versions.
    • Updated the aliases section as suggested:
      "aliases": [
        {
          "base": "original",
          "alias": "plain"
        },
        {
          "base": "original-wordmark",
          "alias": "plain-wordmark"
        }
      ]
      

I've committed these changes and pushed them to the repository. The pull request now shows 2 commits. Could you please review the changes again? Let me know if any further modifications are needed.

canaleal
canaleal previously approved these changes Aug 15, 2024
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 💯
Just added another commit to fix some line artifacts on icomoon for the line SVGs.

@canaleal canaleal changed the title Add laminas icon (devicons#2234) new icon: laminas (original, original-wordmark, line, line-wordmark) Aug 17, 2024
@canaleal canaleal changed the base branch from master to develop August 23, 2024 03:05
@canaleal canaleal dismissed their stale review August 23, 2024 03:05

The base branch was changed.

@canaleal
Copy link
Member

No artifacts and all SVGs are good. Great work:

image

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 94bacf0 into devicons:develop Nov 17, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: laminas (original, original-wordmark, line, line-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICON REQUEST]: laminas/mezzio
3 participants