Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: bash (original, plain) #2263

Merged
merged 6 commits into from
Dec 23, 2024
Merged

update icon: bash (original, plain) #2263

merged 6 commits into from
Dec 23, 2024

Conversation

Finii
Copy link

@Finii Finii commented Sep 5, 2024

[why]
When calculating the bounding box of the icon the real icon is too far right. There is in fact a invisible box on the real icon's left.

[how]
Edit svg file directly (in vi) and just remove the outline's description.

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Load icon into inkscape and just select all - note the ghost square on the left ?!

image

Removed path marked blue:

image

This PR closes NONE

Notes

@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)

fatihbaltaci and others added 2 commits September 4, 2024 03:15
@fatihbaltaci
Fix code block style
41c6828
@Finii
bash: Remove invisible outline of plain icon
2515d79 
[why]
When calculating the bounding box of the icon the real icon is too far
right. There is in fact a invisible box on the real icon's left.

[how]
Edit `svg` file directly (in vi) and just remove the outline's
description.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii changed the title bash: Remove invisible outline of plain icon update icon: bash: Remove invisible outline of plain icon Sep 5, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal and lunatic-fox and removed request for a team September 25, 2024 09:11
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 19, 2024
@canaleal canaleal changed the title update icon: bash: Remove invisible outline of plain icon update icon: bash (original, plain) Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

The PR's base branch is `master`, but should be `develop`
Please change the PR so that it's based on, and merged into `develop`

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

canaleal
canaleal previously approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Hope you don't mind but I also updated the original svg as the old version did not reach the edges of the viewbox.

image

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

The PR's base branch is `master`, but should be `develop`
Please change the PR so that it's based on, and merged into `develop`

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal changed the base branch from master to develop December 23, 2024 02:28
@canaleal canaleal dismissed their stale review December 23, 2024 02:28

The base branch was changed.

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit a961522 into devicons:develop Dec 23, 2024
5 checks passed
@Finii Finii deleted the bugfix/bash-plain branch December 23, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Finii @canaleal @Snailedlt @fatihbaltaci