-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: OCaml (original, original-wordmark, plain, plain-wordmark) #502
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run some optimisations to reduce file size. I used https://www.svgviewer.dev/ as well as some manual editing. Please see the results :)
As you can see in the screenshots posted by our bot, the |
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
Hi! Everything looks great. Good job! Have a nice day, |
The only thing to do is to remove the white background, right? |
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
Hi! Everything looks great. Good job! Have a nice day, |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Working on it now. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Issues have been fixed. |
Hi! Everything looks great. Good job! Have a nice day, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray! OCaml will be part of our next release! Thanks for contributing @Panquesito7!
I added an icon for the OCaml programming language.
original
was taken from the https://icon-icons.com/es/icono/ocaml-logotipo/170902 website.original-wordmark
was taken and slightly modified from Wikipedia.plain
was taken from the https://icon-icons.com/es/icono/ocaml-logotipo/145019 website.plain-wordmark
was taken and slightly modified from ocaml/ocaml-logo#2 (comment).All the images were resized using the
resize-image
tool. 🙂This is how they look:
If I missed up anything, please let me know. Thank you.