Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Move push_folder_to_github method to the utils.py #707

Merged
merged 10 commits into from
Jun 1, 2022

Conversation

pauline-n
Copy link
Collaborator

@pauline-n pauline-n self-assigned this May 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #707 (0840b4b) into develop (516d182) will decrease coverage by 11.49%.
The diff coverage is 10.00%.

@@             Coverage Diff              @@
##           develop     #707       +/-   ##
============================================
- Coverage    59.21%   47.71%   -11.50%     
============================================
  Files          176      191       +15     
  Lines         5455     6776     +1321     
  Branches       490      490               
============================================
+ Hits          3230     3233        +3     
- Misses        2219     3537     +1318     
  Partials         6        6               
Impacted Files Coverage Δ
data_updates/Python/iati_rhfp.py 0.00% <0.00%> (ø)
data_updates/Python/oecd_data.py 0.00% <0.00%> (ø)
data_updates/utils.py 31.25% <11.11%> (-25.90%) ⬇️
data_updates/Python/iati_transaction_spec.py 0.00% <0.00%> (ø)
...ta_updates/Python/iati_transactions_reconfigure.py 0.00% <0.00%> (ø)
data_updates/Python/povcal_smy.py 0.00% <0.00%> (ø)
data_updates/Python/manual_data.py 0.00% <0.00%> (ø)
data_updates/Python/download_oecd.py 0.00% <0.00%> (ø)
data_updates/Python/povcal_agg.py 0.00% <0.00%> (ø)
data_updates/Python/constants.py 0.00% <0.00%> (ø)
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pauline-n pauline-n requested a review from ThatcherK May 26, 2022 09:30
ThatcherK
ThatcherK previously approved these changes May 26, 2022
Copy link
Contributor

@ThatcherK ThatcherK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

@pauline-n pauline-n marked this pull request as ready for review May 26, 2022 09:56
@ThatcherK
Copy link
Contributor

This has to be tested on staging before we merge it

@edwinmp edwinmp force-pushed the feature/move-push-folder-method-to-utils branch from 3c42d9f to 4277934 Compare May 27, 2022 06:12
@edwinmp
Copy link
Collaborator

edwinmp commented May 27, 2022

This has to be tested on staging before we merge it

@ThatcherK could you take @pauline-n through how to do this

@ThatcherK
Copy link
Contributor

@edwinmp yes, that's what I intend to do

@edwinmp
Copy link
Collaborator

edwinmp commented May 30, 2022

@ThatcherK @pauline-n what's the update on this? Want to push a release today & need to know if this will be ready for it

@ThatcherK
Copy link
Contributor

@edwinmp Let me work on this with @pauline-n after standup...

@ThatcherK ThatcherK force-pushed the feature/move-push-folder-method-to-utils branch 2 times, most recently from ff51099 to 0840b4b Compare June 1, 2022 13:41
@ThatcherK ThatcherK force-pushed the feature/move-push-folder-method-to-utils branch from 0840b4b to d7dda07 Compare June 1, 2022 13:43
@ThatcherK ThatcherK merged commit acb1d5b into develop Jun 1, 2022
@ThatcherK ThatcherK deleted the feature/move-push-folder-method-to-utils branch June 1, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants