Add DMY with dot separator date format #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this, this seems like a good change to me. There are some pretty obvious limitations around parsing other formats that aren't prevalent in the US, I wonder if the parser could query the system's locale to decide how to parse an ambiguous date such as "5/6/2023". But that's a problem for another day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add date format with dot separator. This date format is used in the EU and especially in German speaking countries. In contrast to the existing date formats which are month first, this one is day first. Like this:
in contrast to
I changed the parsing that now dates separated with dot are interpreted as day first and the others (dash, slash) are interpreted as month first.