-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test first touch #397
Test first touch #397
Conversation
Do we really want an entire new Travis build just for testing first touch ? |
Try all the tests once without first touch and once with. How are you imagining this differently? |
not sure, a number of tests/examples parametrised over first touch? |
What are the advantages of that compared to a separate build?
|
I am under the assumption that we have constrained build capacity on our Travis account. Can you enlighten me here @mlange05 ? |
In theory we can run as many builders as we like (up to like 23 or something arbitrary). However, they won't all be run in parallel with each other, especially on busy days, so your overall overturn-time will still increase. I've rarely seen more than 4 in parallel, although that maybe a flaky observation, so keeping the number of builders reasonably small to achieve the desired coverage is still a good thing. Regardless, of the number of builders, travis is still red, so we might want to address that one first. @navjotk |
Oh that's because I only added the first touch build to highlight the fact that first touch is broken again. I haven't actually fixed it yet. Is it a problem to leave this PR open as a reminder? |
1147297
to
90c5eb0
Compare
cf4f6b5
to
1c73e50
Compare
This depends on #320 . Closing until the bug is fixed. |
No description provided.