Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test first touch #397

Closed
wants to merge 1 commit into from
Closed

Test first touch #397

wants to merge 1 commit into from

Conversation

navjotk
Copy link
Member

@navjotk navjotk commented Nov 2, 2017

No description provided.

@FabioLuporini
Copy link
Contributor

Do we really want an entire new Travis build just for testing first touch ?

@navjotk
Copy link
Member Author

navjotk commented Nov 6, 2017

Try all the tests once without first touch and once with. How are you imagining this differently?

@FabioLuporini
Copy link
Contributor

not sure, a number of tests/examples parametrised over first touch?

@navjotk
Copy link
Member Author

navjotk commented Nov 8, 2017

What are the advantages of that compared to a separate build?
The advantages of a separate build are:

  • Having a separate build means all (new) tests are automatically run in both configurations unless explicitly turned off. As a corollary, we won't be missing bugs because someone forgot to update travis.yml to configure a new test to run with first touch. That seems like a good thing to me.
  • Having a separate build means we are running tests in parallel so individual builds don't last as long.

@FabioLuporini
Copy link
Contributor

I am under the assumption that we have constrained build capacity on our Travis account. Can you enlighten me here @mlange05 ?

@mlange05
Copy link
Contributor

In theory we can run as many builders as we like (up to like 23 or something arbitrary). However, they won't all be run in parallel with each other, especially on busy days, so your overall overturn-time will still increase. I've rarely seen more than 4 in parallel, although that maybe a flaky observation, so keeping the number of builders reasonably small to achieve the desired coverage is still a good thing.

Regardless, of the number of builders, travis is still red, so we might want to address that one first. @navjotk

@navjotk
Copy link
Member Author

navjotk commented Nov 14, 2017

Oh that's because I only added the first touch build to highlight the fact that first touch is broken again. I haven't actually fixed it yet. Is it a problem to leave this PR open as a reminder?

@navjotk
Copy link
Member Author

navjotk commented Feb 19, 2018

This depends on #320 . Closing until the bug is fixed.

@navjotk navjotk closed this Feb 19, 2018
@navjotk navjotk deleted the test_first_touch branch May 8, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants