Fixed and tested Interfaces.TimeData save parameter #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincepandolfo
force-pushed
the
test_save
branch
2 times, most recently
from
fe3acf6 to
f688c3d
Compare
devito/interfaces.py
Outdated
vincepandolfo
force-pushed
the
test_save
branch
from
f688c3d to
7486e3d
Compare
Contributor
|
if @navjotk is happy with this, I think we can merge |
vincepandolfo
force-pushed
the
test_save
branch
from
be44090 to
a6b7aee
Compare
ZoeLeibowitz
added a commit
that referenced
this pull request
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little issue: The final result is at
timesteps - 2while one would expect it to be attimesteps - 1since the Devito calculated values start from 0.My guess is that the result when
save=Falseis not the 100th timestep, but the 99th. I can't see why that would happen though.EDIT: Added issue #69 regarding this problem