-
Notifications
You must be signed in to change notification settings - Fork 247
Gradient test #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient test #76
Conversation
|
Currently fails because of memory and permission error for deployement |
|
Only fails because of memory on linux travis, apple passes |
|
@navjotk @mlange05 Time_substitution is still there as this was created from Zhang. I made a change to Finally i moved most of the |
examples/Acoustic_codegen.py
Outdated
| damp_boundary(self.damp.data) | ||
|
|
||
| self.src = SourceLike(name="src", npoint=1, nt=self.nt, dt=self.dt, h=self.h, | ||
| self.src = SourceLike(name="src", npoint=1, nt=data.traces.shape[1], dt=self.dt, h=self.model.get_spacing(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really try hard to have lines shorter than 90 characters
|
I'll go through this properly later, but we should start having smaller, lighter PRs |
|
@FabioLuporini |
|
The inversion repo is based on this branch so @vincepandolfo (because you worked already on inversion an looked a bit a this branch) and @mlange05 can we get this one going. |
devito/compiler.py
Outdated
|
|
||
| if self.openmp: | ||
| print "WARNING: Disabling OpenMP because clang does not support it." | ||
| print("WARNING: Disabling OpenMP because clang does not support it.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use logger module here
tests/test_gradient.py
Outdated
| from examples.containers import IGrid, IShot | ||
|
|
||
|
|
||
| class Test_Gradient(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One shouldn't use _ for class names -- I think it's quite a common rule in Python
Rewrite of the Acoustic and TTI operators and codegen to separate operator, model and data.
Gradient test is also back in even so it may be too memory expensive for travis.