Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3ds-libdl. #101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add 3ds-libdl. #101

wants to merge 3 commits into from

Conversation

TSnake41
Copy link

As possibly needed with #85. This is a extendable stub implementation of libdl.

It implements a "fake" libdl that can be needed for some libraries (like LuaJIT FFI).
You can (if needed) change the functions bound to the stub library using dl_setfn().

@WinterMute WinterMute requested review from fincs and mtheall July 11, 2019 18:42
Copy link
Member

@fincs fincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this is merged, it might be worth doing a switch-libdl too.

build() {
source /opt/devkitpro/3dsvars.sh

arm-none-eabi-gcc $CFLAGS -c -o dlfcn.o dlfcn.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use $(CC) here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${CC} is currently not defined in 3dsvars.sh, however, ${TOOL_PREFIX} is defined to arm-none-eabi- and is actually used to define ${AR}, so to get ${CC}, and can use ${TOOL_PREFIX}gcc.

3ds/libdl/PKGBUILD Outdated Show resolved Hide resolved
3ds/libdl/PKGBUILD Outdated Show resolved Hide resolved
3ds/libdl/dlfcn.c Outdated Show resolved Hide resolved
3ds/libdl/dlfcn.c Outdated Show resolved Hide resolved
@fincs fincs requested a review from WinterMute July 11, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants