Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust spelling in readme and index #21

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

LukaszKokot
Copy link
Contributor


name: New Pull Request
about: Improving spelling
title: 'Adjust spelling in readme and index'
labels: 'hacktoberfest'
assignees: 'devlato'

Describe the problem this PR solves
Fixes some spelling issues I've seen in the README.md and index.ts files.

Features and behaviour
No new features or behaviour.

Describe how it solves the problem
No problem to solve

Additional context
Used this library today in an electron app, so wanted to thank you by improving the readme a tiny little bit.

Copy link
Owner

@devlato devlato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @LukaszKokot! I always have known there have been dozens of typos, but I couldn't find enough time to re-read everything through attentively enough.

Could you please bump the minor version in package.json, so that these changes could go live? The build will pick these changes up and auto-release everything once this PR's merged, if the package version's different.

@LukaszKokot
Copy link
Contributor Author

Thanks @devlato, my pleasure! I've added another commit that bumps the version as requested 🙂

@devlato
Copy link
Owner

devlato commented Oct 15, 2021

Thanks a lot @LukaszKokot! 🙂

@devlato devlato merged commit 7e7178d into devlato:master Oct 15, 2021
@devlato
Copy link
Owner

devlato commented Oct 15, 2021

@LukaszKokot thanks, I can confirm that 2.0.8 is now live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants