Make sure we don't duplicate Orleans-generated code#154
Merged
Conversation
kzu
force-pushed
the
dev/OrleansGeneratorFix
branch
4 times, most recently
from
4c4fbd0 to
67b456d
Compare
Since we include the Orleans.CodeGenerator.dll as part of our analyzers, the original source generator there was also being exposed through our assembly, causing Roslyn to invoke essentially the same generator twice. This resulted in duplicate code that made our project unusable. To avoid this duplication, we ILMerge the Orleans assembly but at the same time remove the generator from it (using Cecil and a simple dotnet file app).
kzu
force-pushed
the
dev/OrleansGeneratorFix
branch
from
67b456d to
9babec2
Compare
Member
Author
|
🧪 Details on Ubuntu 24.04.3 LTS🧪 Details on macOS Unix 15.7.1🧪 Details on Microsoft Windows 10.0.26100from dotnet-retest v1.0.0 on .NET 9.0.10 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we include the Orleans.CodeGenerator.dll as part of our analyzers, the original source generator there was also being exposed through our assembly, causing Roslyn to invoke essentially the same generator twice. This resulted in duplicate code that made our project unusable.
To avoid this duplication, we ILMerge the Orleans assembly but at the same time remove the generator from it (using Cecil and a simple dotnet file app).