Allow relaxing snapshot version compatibility #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than hardcoding a major+minor compatiiblity check between persisted state and current state assembly version, allow relaxing to major version only too. It's typical in SemVer to use strictly major-only bumps when introducing significant state/API breakage, so if the user uses that, we can relax the requirement on the snapshot reading. This can significantly improve performance when event steam is long and the app is frequently updated but with minor version bumps and no state breaking changes.
kzu
force-pushed
the
dev/SnapshotCompatibility
branch
from
77f4fd3 to
1e56c0f
Compare
Member
Author
|
🧪 Details on Microsoft Windows 10.0.26100from dotnet-retest v1.0.0 on .NET 9.0.10 with 💜 by @devlooped |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow relaxing snapshot version compatibility
Rather than hardcoding a major+minor compatiiblity check between persisted state and current state assembly version, allow relaxing to major version only too.
It's typical in SemVer to use strictly major-only bumps when introducing significant state/API breakage, so if the user uses that, we can relax the requirement on the snapshot reading. This can significantly improve performance when event steam is long and the app is frequently updated but with minor version bumps and no state breaking changes.