Switch to Polysharp and allow null strings in TryParse

devlooped · Mar 28, 2023 · 4cf3194 · 4cf3194
1 parent d2e08c6
commit 4cf3194
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/CloudStorageAccount.Source/CloudStorageAccount.Source.csproj b/src/CloudStorageAccount.Source/CloudStorageAccount.Source.csproj
@@ -19,7 +19,7 @@
     <PackageReference Include="Azure.Storage.Queues" Version="12.13.1" />
     <PackageReference Include="Azure.Data.Tables" Version="12.8.0" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
-    <PackageReference Include="Nullable" Version="1.3.1" />
+    <PackageReference Include="PolySharp" Version="1.12.1" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/CloudStorageAccount/CloudStorageAccount.cs b/src/CloudStorageAccount/CloudStorageAccount.cs
@@ -354,7 +354,7 @@ public static CloudStorageAccount Parse(string connectionString)
     /// <param name="account">A <see cref="CloudStorageAccount"/> object to hold the instance returned if
     /// the connection string can be parsed.</param>
     /// <returns><b>true</b> if the connection string was successfully parsed; otherwise, <b>false</b>.</returns>
-    public static bool TryParse(string connectionString, [NotNullWhen(true)] out CloudStorageAccount? account)
+    public static bool TryParse(string? connectionString, [NotNullWhen(true)] out CloudStorageAccount? account)
     {
         if (string.IsNullOrEmpty(connectionString))
         {
@@ -364,7 +364,7 @@ public static bool TryParse(string connectionString, [NotNullWhen(true)] out Clo
 
         try
         {
-            return ParseImpl(connectionString, out account, err => { });
+            return ParseImpl(connectionString!, out account, err => { });
         }
         catch (Exception)
         {

diff --git a/src/CloudStorageAccount/CloudStorageAccount.csproj b/src/CloudStorageAccount/CloudStorageAccount.csproj
@@ -16,7 +16,7 @@
     <PackageReference Include="Azure.Storage.Queues" Version="12.13.1" />
     <PackageReference Include="Azure.Data.Tables" Version="12.8.0" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
-    <PackageReference Include="Nullable" Version="1.3.1" PrivateAssets="all" />
+    <PackageReference Include="PolySharp" Version="1.12.1" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>