Skip to content

Don't generate any of the registrations during design-time #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Apr 24, 2025
Merged

Don't generate any of the registrations during design-time #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/DependencyInjection/Devlooped.Extensions.DependencyInjection.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
<ItemGroup>
<CompilerVisibleProperty Include="AddServiceAttribute" />
<CompilerVisibleProperty Include="AddServicesExtension" />
<!-- To quickly exit if true -->
<CompilerVisibleProperty Include="DesignTimeBuild" />
</ItemGroup>

<ItemGroup Condition="'$(IsEditor)' != 'true'">
Expand Down
7 changes: 4 additions & 3 deletions src/DependencyInjection/IncrementalGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
{
(var compilation, var options) = x;

// We won't add any registrations in this case.
if (!options.GlobalOptions.TryGetValue("build_property.AddServicesExtension", out var value) ||
// We won't add any registrations in these cases.
if (options.IsDesignTimeBuild() ||
!options.GlobalOptions.TryGetValue("build_property.AddServicesExtension", out var value) ||
!bool.TryParse(value, out var addServices) || !addServices)
return Enumerable.Empty<INamedTypeSymbol>();
return [];

var visitor = new TypesVisitor(s => compilation.IsSymbolAccessible(s), c);
compilation.GlobalNamespace.Accept(visitor);
Expand Down