Simplify approach to Grok chat client and dynamic clients #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to provide the intuitive behavior of honoring the ChatOptions.ModelId, which the OpenAI client doesn't do. In order to achieve this, we implement the switching in the new GrokChatClient instead, and keep the GrokClient as a fallback for existing code or other non-chat scenarios where the same endpoints might work (but it's not guaranteed at all).
Member
Author
|
🧪 Details on Ubuntu 24.04.2 LTSfrom dotnet-retest v0.7.1 on .NET 8.0.17 with 💜 by @devlooped |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide the intuitive behavior of honoring the ChatOptions.ModelId, which the OpenAI client doesn't do. In order to achieve this, we implement the switching in the new GrokChatClient instead, and keep the GrokClient as a fallback for existing code or other non-chat scenarios where the same endpoints might work (but it's not guaranteed at all).