Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from v2 -> v3 #240

Closed
Lonli-Lokli opened this issue Feb 17, 2023 · 6 comments
Closed

Migration from v2 -> v3 #240

Lonli-Lokli opened this issue Feb 17, 2023 · 6 comments
Labels

Comments

@Lonli-Lokli
Copy link

Describe the Bug

What are the steps I should perform to migrate to the version 3?

Steps to Reproduce

public class ReproTest
{
  [Fact]
  public void Repro()
  {
    // arrange
    // act
    // assert
  }
}

Expected Behavior

Exception with Stack Trace

Put the exception with stack trace here.

Version Info

Additional Info

@Lonli-Lokli Lonli-Lokli changed the title Migration from 2 -> 4 Migration from v2 -> v3 Feb 17, 2023
@kzu
Copy link
Member

kzu commented Feb 17, 2023

None, everything should Just Work as always.

If something isn't, plz file a bug 🙏 . Thanks!

@kzu kzu closed this as completed Feb 17, 2023
@Lonli-Lokli
Copy link
Author

My code just do not compile with strange error, can it be treated as bug? ;)

@kzu
Copy link
Member

kzu commented Feb 18, 2023

If you provide a clean repro and/or a binlog, sure!

@Lonli-Lokli
Copy link
Author

Lonli-Lokli commented Feb 19, 2023

@kzu
Copy link
Member

kzu commented Feb 21, 2023

Ok, found the root cause and have a fix. GitInfo now sets <Version> by default, but you can turn that off to get the legacy behavior by setting GitVersion=false.

@kzu
Copy link
Member

kzu commented Feb 22, 2023

Tried the new CI build on the provided repo with GitInfo version 42.42.206-main and the following to restore from the CI feed:

    <PropertyGroup>
        ...
        <RestoreSources>https://pkg.kzu.io/index.json;https://api.nuget.org/v3/index.json</RestoreSources>
    </PropertyGroup>

And it now works as expected. Please reopen if something's off. I'll ship the release ASAP.

@kzu kzu closed this as completed Feb 22, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants