Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace / and \ in branches with dashes when setting default Version #248

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

kzu
Copy link
Member

@kzu kzu commented Feb 21, 2023

Do this only when setting a default Version since otherwise the build fails. But we don't want to change the determined GitBranch so it remains accurate.

Closes #244 and #240

Do this only when setting a default Version since otherwise the build fails. But we don't want to change the determined GitBranch so it remains accurate.

Closes #244.
@kzu kzu added the bug label Feb 21, 2023
@kzu kzu enabled auto-merge (rebase) February 21, 2023 23:43
@kzu kzu merged commit 1a92d60 into main Feb 21, 2023
@kzu kzu deleted the replace-dashes branch February 21, 2023 23:44
@kzu kzu mentioned this pull request Feb 21, 2023
@kzu kzu changed the title Replace / and \ in branches with dashes Replace / and \ in branches with dashes when setting default Version Feb 22, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch Names with '/' generate invalid versions
1 participant