Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"_" is not allowed in nuget version strings #294

Closed
wants to merge 1 commit into from

Conversation

smorokin
Copy link
Contributor

The problem is the same as in #244 which was fixed in #248. This pr would simply replace all underscores in a branch name with dashes.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@tobsil
Copy link

tobsil commented Jul 28, 2023

Hello,
we use $([System.Text.RegularExpressions.Regex]::Replace($(GitBranch), "[^0-9A-Za-z-]", "-")) in our project files. This replaces all not allowed characters in the branch name with a '-'.
This was derived from https://semver.org/ proposed Regexp (FAQ: "Is there a suggested regular expression (RegEx) to check a SemVer string?")

I think this would be a more complete approach to the underlying problem.

@tobsil
Copy link

tobsil commented Jul 31, 2023

@smorokin I saw your last commit in your fork but this is not reflected in this pull request. I'm not sure but I think you have update or recreate your pull request.

@smorokin
Copy link
Contributor Author

@tobsil Yes I thought it takes a while to update the PR. Seems like I have to do another

@smorokin smorokin closed this Jul 31, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants