THIS001 warning on F# project

[svdijk]

Describe the Bug

When GitInfo is installed in an F# project, the following warning is emitted when the project is built:

C:\Users\<username>\.nuget\packages\thisassembly.prerequisites\1.2.9\build\netstandard2.0\ThisAssembly.Prerequisites.targets(16,5): warning THIS001: ThisAssembly requires Compiler API (Roslyn) version 4.0 or greater.

Steps to Reproduce

• Create a new directory
• Create an empty git repository in it
• In Visual Studio, create a new F# Class Library project in this directory
• Create an initial commit
• Install GitInfo in the project
• Build the project

Expected Behavior

Build without any warnings.

Version Info

• Visual Studio 2022 (Version 17.4.5)
• GitInfo 3.0.4

Additional Info

This seems to be specific to F# projects. When following the "Steps to Reproduce", but creating a C# Class Library project instead, this warning is not emitted.

Edit: I've added some debug messages to the file from which the THIS001 warning originates. For the C# project RoslynVersion is 4.4, but for the F# project RoslynVersion ends up at 0.0.

[kzu]

Yes, this is a C# only warning, but unfortunately, NuGet does not allow you to selectively take dependencies pivoting on the consuming project language.

So I'd suggest just adding a <NoWarn>THIS001</NoWarn> to your project, which should take care of it.

[svdijk]

Thanks, I already did that as a test, but it's good to have it confirmed as the "official" solution/workaround.

I now have

<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.fsproj'">
  <NoWarn>THIS001</NoWarn>
</PropertyGroup>

in my Directory.Build.props (as there are both C# and F# projects in my solution). Perhaps something along these lines (probably a bit more fancy) could be considered for GitInfo? I think ThisAssembly should indeed emit this warning for an F# project, but for GitInfo it could be nice to prevent the warning from being emitted in this case.

[kzu]

Yeah, in thinking that perhaps the warning could check the language too and just skip it for F#...