Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #98 #110

Merged
merged 1 commit into from
Aug 3, 2020
Merged

fixed #98 #110

merged 1 commit into from
Aug 3, 2020

Conversation

pedoc
Copy link
Contributor

@pedoc pedoc commented Apr 8, 2020

set all Exec.StdOutEncoding='utf-8'

Problems:
1.When the solution is in a non-ASCII character set path, the solution cannot be compiled, and the exception message is:"System.IO.DirectoryNotFoundException"
image

2.When there are non-ASCII characters in the git commit information or branch name or tag, there are garbled characters in the automatically generated ThisAssembly.g.cs
image

After analysis, it was found that the above-mentioned problems were caused by the incorrect default encoding used by msbuild.exe or dotnet msbuild when executing the Exec task in Target.

Solution:
Specify the output encoding of all Target->Exec tasks as 'utf-8',append code to Exec:

StdOutEncoding='utf-8'

@kzu
Copy link
Member

kzu commented Apr 8, 2020

Thanks a lot for looking into this! Will merge as soon as the commit message is a bit clearer 💯

@kzu kzu self-requested a review April 8, 2020 18:43
Copy link
Member

@kzu kzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe amend the commit and add a bit more explanation on why this is necessary and what it fixes? (for posterity :)).

@pedoc
Copy link
Contributor Author

pedoc commented Apr 9, 2020

Maybe amend the commit and add a bit more explanation on why this is necessary and what it fixes? (for posterity :)).

hi,
I made changes to the commit message,please review

I'm sorry, my English is not good :)

@kzu
Copy link
Member

kzu commented Jul 22, 2020

Hi @pedoc , the commit still shows plainly as:

image

You should amend the commit, and provide a commit that explains what it achieves. This is a good writeup on what makes a good commit message.

Thanks!

@kzu
Copy link
Member

kzu commented Jul 22, 2020

Oh, I think you're editing the pull request title and description, but that's not changing the commit itself. You'd need to push an updated commit to achieve that

… path. the exception message is:"System.IO.DirectoryNotFoundException"
@pedoc
Copy link
Contributor Author

pedoc commented Jul 29, 2020

@kzu Sorry I didn’t understand what you meant at first, now it’s processed. :)

@kzu
Copy link
Member

kzu commented Aug 3, 2020

Awesome 👍 . Thanks!

@kzu kzu merged commit 061e9db into devlooped:master Aug 3, 2020
@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants