Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitThisAssemblyMetadata #112

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix GitThisAssemblyMetadata #112

merged 1 commit into from
Jul 22, 2020

Conversation

joacar
Copy link
Contributor

@joacar joacar commented Apr 20, 2020 •
edited
Loading

Fix #108 by explicitly declaring property before used. Default behavior is preserved by defaulting to false. Attached sample program and NuGet

Environment

$ dotnet --version
3.1.300-preview-015048
$ dotnet msbuild --help
Microsoft (R) Build Engine version 16.6.0-preview-20162-03+00781ad13 for .NET Core

CSharp.zip

@kzu
Copy link
Member

kzu commented Jul 22, 2020

I don't fully understand how this could make a difference, but it's harmless to declare it :)

@kzu kzu merged commit 9bd627b into devlooped:master Jul 22, 2020
@joacar
Copy link
Contributor Author

joacar commented Jul 23, 2020

Me neither :) Thanks for merging

@joacar joacar deleted the GitThisAssemlbyMetadata branch July 23, 2020 09:36
@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASP.NET Core 3.1 GitThisAssemblyMetadata setting?
2 participants
@joacar @kzu