Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pull request #118 was closed accidentally.
Add preprocessor definitions (macros) with git info to C++ and resource compiler.
Using this way is because there's no easy way to inject global variables into a source file. Users are required to include a header in order to use generated git info.
And C++ has multiple char types, for example
"str"
ischar[]
andL"str"
wchar_t[]
. And there's no easy way to do a compile-time conversion.But with macros, we can just use a macro like
#define WSTRIFY(s) L##s
to make it becomewchar_t[]
Also the resource compiler doesn't support global variables, but macros are supported.
Currently there's a issue that Visual Studio says
identifier "GIT_*" is undefined
. A solution is to write a stub header file that checks existence these macros and define them if not exist.Another option is to generate a header file with preprocessor definitions, and let user manually include it. Which one is better?
May closes #67, but I'm not familiar with managed C++.