Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for git in WSL #31

Merged
merged 4 commits into from
Apr 12, 2017
Merged

Add support for git in WSL #31

merged 4 commits into from
Apr 12, 2017

Conversation

chkn
Copy link
Contributor

@chkn chkn commented Apr 10, 2017

This adds support for using git installed in WSL (Windows Subsystem for Linux).

@chkn
Copy link
Contributor Author

chkn commented Apr 11, 2017

Actually, there is an issue with this. The _ShortShaFormat and _LongShaFormat properties need to be the single % case. The current condition for that is Condition="'$(OS)' != 'Windows_NT'". I'm thinking perhaps adding a new variable for this, something like IsUnixlike perhaps?

@kzu
Copy link
Member

kzu commented Apr 11, 2017

So under WSL the $(OS) for MSBuild is reported as Windows_NT?? :\

Alex Corrado added 3 commits April 11, 2017 15:49
We needed to translate the Windows paths into Unix paths
in a couple places.
It is much faster
@kzu kzu merged commit ee146a1 into devlooped:master Apr 12, 2017
@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants