Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast up-to-date-check #343

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix fast up-to-date-check #343

merged 1 commit into from
May 30, 2024

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented May 20, 2024

Fixes #322.

I looked into fast up-to-date-check and I think the ideal is to track the same inputs and outputs used for incremental builds, so I refactored the git info targets to use the utdc design-time targets to dynamically add the git inputs marked with utdc metadata. Furthermore, I put them in to their own utdc group to correlate the git info specific inputs and outputs.

I removed the git head cache since during my debugging I saw warnings like InputModifiedSinceLastSuccessfulBuildStart which indicated it was a bad idea. Besides, the utdc cache is only updated during design-time builds, which I could only trigger by editing the project file itself. This is also why I didn't include inputs from refs/heads/** or refs/tags/** since adding or deleting branches or tags wouldn't be picked up until the next design-time build, which can be annoying/confusing. I think it would be good to merge the git dirty cache into the git info cache for the same reasons but I left that for now, although I did add that file to the utdc inputs anyway.

Add git info specific inputs and outputs used for incremental builds.
@kzu
Copy link
Member

kzu commented May 30, 2024

Very nice improvement! Thanks a lot for your contribution(s!) 💪

@kzu kzu merged commit 67821b8 into devlooped:main May 30, 2024
6 checks passed
@gitfool gitfool deleted the gh322 branch May 30, 2024 03:25
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects don't rebuild after committing
2 participants