Don't do xbuild things on Windows #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET Core's msbuild doesn't set MSBuildRuntimeVersion, so it gets treated as xbuild, breaking the build.
kzu
approved these changes
Jun 15, 2017
abock
added a commit
to abock/GitInfo
that referenced
this pull request
Aug 15, 2017
MSBuildRuntimeTime is never set by xbuild, but it can also be used to differentiate .NET Framework or .NET Core (e.g. it'll be 'Core' on .NET Core). This ensures GitInfo works under `dotnet build` and friends on macOS as well as Windows. Improves upon PR devlooped#42. Thanks to @bojanrajkovic for the suggestion.
kzu
pushed a commit
that referenced
this pull request
Aug 15, 2017
MSBuildRuntimeTime is never set by xbuild, but it can also be used to differentiate .NET Framework or .NET Core (e.g. it'll be 'Core' on .NET Core). This ensures GitInfo works under `dotnet build` and friends on macOS as well as Windows. Improves upon PR #42. Thanks to @bojanrajkovic for the suggestion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core's msbuild doesn't set MSBuildRuntimeVersion, so it gets treated as
xbuild, breaking the build.
Fixes #41.