Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow counting all commits in the repository #66

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Allow counting all commits in the repository #66

merged 1 commit into from
Jun 1, 2018

Conversation

alanmcgovern
Copy link
Contributor

If you set a directory, even '.' or the full path to the repository root, you will end
up ignoring all empty commits. The reason, i suspect, is that when you count
commits for the full repository (git log) it doesn't do any filtering. However once
you specify a path, even if it's the repository root, it filters out all commits which
do not change files within that subtree. As empty commits do not change files,
these are always discarded.

If someone wants to discard empty commits they can always manually specify
<GitCommitsRelativeTo>.</GitCommitsRelativeTo>

If you set a directory, even '.' or the full path to the repository root, you will end
up ignoring all empty commits. The reason, i suspect, is that when you count
commits for the full repository (git log) it doesn't do any filtering. However once
you specify a path, even if it's the repository root, it filters out all commits which
do *not* change files within that subtree. As empty commits do not change files,
these are always discarded.

If someone wants to discard empty commits they can always manually specify
`<GitCommitsRelativeTo>.</GitCommitsRelativeTo>`
@kzu kzu merged commit 96b9749 into devlooped:master Jun 1, 2018
@alanmcgovern
Copy link
Contributor Author

From local testing:

<GitCommitsRelativeTo>.</GitCommitsRelativeTo> .  ->     GitSemVerPatch:       85
<GitCommitsRelativeTo></GitCommitsRelativeTo>     ->    GitSemVerPatch:       94

@alanmcgovern alanmcgovern deleted the patch-1 branch June 1, 2018 14:53
@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants