Ensure we normalize to the correct path separator #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git rev-parse --show-toplevel emits unix style separator characters. This breaks our logic later down the line as we compare two paths and that causes the comparison to fail. for example: `git rev-parse --show-toplevel` produces `C:/Projects/whatever` and `GitRoot` is `c:\Projects\whatever` Now both will normalize to `c:\Projects\whatever\`
|
@kzu should be good to go. It worked for me locally |
|
Thanks! 💯 |
|
Sigh, it was |
|
Normalise directory exists too - it ensures the paths end in a directory separator char |
|
What version is that? Because it failed on CI too
On Mon, Aug 6, 2018, 9:36 AM Alan McGovern ***@***.***> wrote:
https://github.com/Microsoft/msbuild/blob/e5bc7994348dba88d1f6fe2ebd6aa354355f0063/src/Build/Evaluation/IntrinsicFunctions.cs#L406
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKW64soOCwYUzbTZYbtntGzb6aprOgZks5uODhHgaJpZM4Vsi7_>
.
--
…--
/kzu from mobile
|
|
Fixed this in #75 |
|
Fixed in 2.0.15
--
/kzu
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rev-parse --show-toplevel emits unix style separator characters.
This breaks our logic later down the line as we compare two paths
and that causes the comparison to fail.
for example:
git rev-parse --show-toplevelproducesC:/Projects/whateverand
GitRootisc:\Projects\whateverNow both will normalize to
c:\Projects\whatever\