Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match System.Reactive namespaces #9

Closed
kzu opened this issue Sep 27, 2021 · 0 comments · Fixed by #11
Closed

Match System.Reactive namespaces #9

kzu opened this issue Sep 27, 2021 · 0 comments · Fixed by #11
Labels
enhancement New feature or request
Milestone

Comments

@kzu
Copy link
Member

kzu commented Sep 27, 2021

Currently, we provide all types in the top-level System namespace, which makes consumption straightforward but which isn't 100% compatible with System.Reactive.

For example, Rx uses System.Reactive.Linq for the OfType/Where/Select extension methods, System.Reactive.Subjects and System.Reactive.Disposables.

Even though using separate namespaces for just one or two types (in our case) would seem unnecessary, by not using the same namespaces as System.Reactive, this package is not a simple drop-in replacement (neither can it be replaced by just switching to the full Rx package), since compilation errors will need fixing from the namespace mismatches.

We should instead be 100% compatible so that switching packages is all that's needed.

@kzu kzu added the enhancement New feature or request label Sep 27, 2021
kzu added a commit that referenced this issue Sep 28, 2021
This makes RxFree a 100% compatible drop-in replacement if only the provided types are used in a given project. Likewise, if the need arises for feature not provided in RxFree, it's trivial to "migrate" to System.Reactive: just uninstall RxFree and install System.Reactive and start using whatever is missing from this project.

Fixes #9
@kzu kzu closed this as completed in #11 Sep 28, 2021
kzu added a commit that referenced this issue Sep 28, 2021
This makes RxFree a 100% compatible drop-in replacement if only the provided types are used in a given project. Likewise, if the need arises for feature not provided in RxFree, it's trivial to "migrate" to System.Reactive: just uninstall RxFree and install System.Reactive and start using whatever is missing from this project.

Fixes #9
@kzu kzu added this to the 1.1.0 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant