Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dynamic entity support by exposing TableEntity directly #127

Closed
kzu opened this issue Aug 15, 2022 · 1 comment · Fixed by #128
Closed

Improve dynamic entity support by exposing TableEntity directly #127

kzu opened this issue Aug 15, 2022 · 1 comment · Fixed by #128
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Aug 15, 2022 •
edited by devlooped-bot
Loading

In previous versions we made the TableEntityRepository only expose ITableEntity.

This was inconvenient since it required downcasting the returned entities to DynamicTableEntity in order to access its additional properties and manipulate them.

The new Azure.Data.Tables we depend on has a much simpler API for TableEntity, which replaces the old DynamicTableEntity with a simple ITableEntity implementation that just adds an IDictionary<string, object interface on top.

We should should make our entity-based repository/partition expose this new TableEntity object so it's a more effective and intuitive addition to the raw tables API.

Back this issue
Back this issue
@kzu kzu added the enhancement New feature or request label Aug 15, 2022
kzu added a commit that referenced this issue Aug 15, 2022
@kzu
Improve dynamic entity support by exposing TableEntity directly
22e8aa4 
Expose the new and richer TableEntity class from the underlying azure tables API so it's a more effective addition on top of it.

#127
@kzu kzu mentioned this issue Aug 15, 2022
Merged
kzu added a commit that referenced this issue Aug 15, 2022
@kzu
Improve dynamic entity support by exposing TableEntity directly
21d7a98 
Expose the new and richer TableEntity class from the underlying azure tables API so it's a more effective addition on top of it.

#127
@kzu
Copy link
Member Author

kzu commented Aug 16, 2022

Fixed in #128

@kzu kzu closed this as completed Aug 16, 2022
@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve dynamic entity support by exposing TableEntity directly devlooped/TableStorage
1 participant
@kzu