Properly persist computed colums for same type #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug where we cached the list of properties to persist by type, without regard for the variability in PK/RK names which can be different when persisting the same entity using various key strategies for indexing purposes. By considering these two properties as part of the cache key, we allow proper persistence as originally intended to avoid duplicating PK/RK props. Fixes #252
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug where we cached the list of properties to persist by type, without regard for the variability in PK/RK names which can be different when persisting the same entity using various key strategies for indexing purposes.
By considering these two properties as part of the cache key, we allow proper persistence as originally intended to avoid duplicating PK/RK props.
Fixes #252