Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate PartitionKey/RowKey properties in storage #27

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Don't duplicate PartitionKey/RowKey properties in storage #27

merged 1 commit into from
Jun 14, 2021

Conversation

kzu
Copy link
Member

@kzu kzu commented Jun 14, 2021

Switch to expressions for table repository, so we can inspect the lambda looking for the actual property name being used for partition/row keys. This way we can avoid persisting those as (duplicate) individual columns (since they will already be persisted as partition/row keys).

For document-based storage, we don't need to distinguish, since we persist the entire serialized object, so it's not useful in that case to try to avoid persisting them separately.

Fixes #26

@kzu kzu enabled auto-merge (rebase) June 14, 2021 13:55
Switch to expressions for table repository, so we can inspect the lambda looking for the actual property name being used for partition/row keys. This way we can avoid persisting those as (duplicate) individual columns (since they will already be persisted as partition/row keys).

For document-based storage, we don't need to distinguish, since we persist the entire serialized object, so it's not useful in that case to try to avoid persisting them separately.

Fixes #26
@kzu kzu merged commit 2ad6ce3 into main Jun 14, 2021
@kzu kzu deleted the dev branch June 14, 2021 14:09
@devlooped devlooped locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't duplicate PartitionKey/RowKey properties in storage
1 participant