Skip to content

Bump to latest SponsorLink and ensure private assets always #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Mar 20, 2023
Merged

Bump to latest SponsorLink and ensure private assets always #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ThisAssembly.AssemblyInfo/ThisAssembly.AssemblyInfo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ on the `ThisAssembly.Info` class.
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />

<PackageReference Include="Scriban" Version="5.7.0" Pack="false" IncludeAssets="build" />
Expand Down
9 changes: 9 additions & 0 deletions src/ThisAssembly.AssemblyInfo/ThisAssembly.AssemblyInfo.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project>

<ItemGroup>
<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.AssemblyInfo" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

</Project>
4 changes: 2 additions & 2 deletions src/ThisAssembly.Constants/ThisAssembly.Constants.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ C#:
</ItemGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />

<PackageReference Include="Scriban" Version="5.7.0" Pack="false" IncludeAssets="build" />
Expand Down
4 changes: 4 additions & 0 deletions src/ThisAssembly.Constants/ThisAssembly.Constants.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
<CompilerVisibleItemMetadata Include="Constant" MetadataName="Comment" />
<CompilerVisibleItemMetadata Include="Constant" MetadataName="Value" />
<CompilerVisibleItemMetadata Include="Constant" MetadataName="Root" />

<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.Constants" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

<ItemDefinitionGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/ThisAssembly.Git/ThisAssembly.Git.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
</ItemGroup>

Expand Down
6 changes: 6 additions & 0 deletions src/ThisAssembly.Git/ThisAssembly.Git.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<Project>

<ItemGroup>
<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.Git" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

<PropertyGroup Condition="'$(RepositoryBranch)' == ''">
<!-- GitHub Actions: https://docs.github.com/en/actions/reference/environment-variables#default-environment-variables -->
<RepositoryBranch Condition="'$(RepositoryBranch)' == '' and '$(GITHUB_REF)' != '' and $(GITHUB_REF.Contains('refs/pull/'))">pr$(GITHUB_REF.Replace('refs/pull/', '').Replace('/merge', ''))</RepositoryBranch>
Expand Down
8 changes: 6 additions & 2 deletions src/ThisAssembly.Metadata/ThisAssembly.Metadata.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,12 @@ C#:
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<None Remove="ThisAssembly.Metadata.targets" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />

<PackageReference Include="Scriban" Version="5.7.0" Pack="false" IncludeAssets="build" />
Expand Down
9 changes: 9 additions & 0 deletions src/ThisAssembly.Metadata/ThisAssembly.Metadata.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project>

<ItemGroup>
<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.Metadata" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/ThisAssembly.Prerequisites/ThisAssembly.Prerequisites.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
</ItemGroup>

Expand Down
4 changes: 2 additions & 2 deletions src/ThisAssembly.Project/ThisAssembly.Project.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ C#:
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />

<PackageReference Include="Scriban" Version="5.7.0" Pack="false" IncludeAssets="build" />
Expand Down
8 changes: 7 additions & 1 deletion src/ThisAssembly.Project/ThisAssembly.Project.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<Project>

<ItemGroup>
<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.Project" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

<PropertyGroup>
<InjectThisAssemblyProjectDependsOn Condition="'$(SourceControlInformationFeatureSupported)' == 'true'">
InitializeSourceControlInformation
Expand All @@ -15,7 +21,7 @@
<ThisAssemblyProject>@(ProjectPropertyDistinct, '|')</ThisAssemblyProject>
</PropertyGroup>
<ItemGroup Condition="'$(ThisAssemblyProject)' != ''">
<CompilerVisibleProperty Include="@(ProjectProperty)" />
<CompilerVisibleProperty Include="@(ProjectPropertyDistinct)" />
<CompilerVisibleProperty Include="ThisAssemblyProject" />
</ItemGroup>
</Target>
Expand Down
4 changes: 2 additions & 2 deletions src/ThisAssembly.Resources/ThisAssembly.Resources.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />

<PackageReference Include="Scriban" Version="5.7.0" Pack="false" IncludeAssets="build" />
Expand Down
6 changes: 6 additions & 0 deletions src/ThisAssembly.Resources/ThisAssembly.Resources.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<Project>

<ItemGroup>
<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.Resources" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

<ItemGroup>
<CompilerVisibleProperty Include="EmbeddedResourceStringExtensions" />

Expand Down
4 changes: 2 additions & 2 deletions src/ThisAssembly.Strings/ThisAssembly.Strings.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ such as "Hello {name}".
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Devlooped.SponsorLink" Version="42.42.213-main" />
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />

<PackageReference Include="Scriban" Version="5.7.0" Pack="false" IncludeAssets="build" />
Expand Down
6 changes: 6 additions & 0 deletions src/ThisAssembly.Strings/ThisAssembly.Strings.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<Project>

<ItemGroup>
<!-- Make sure we're always private to the referencing project.
Prevents analyzers from "flowing out" of the referencing project. -->
<PackageReference Update="ThisAssembly.Strings" PrivateAssets="all" PackTransitive="false" />
</ItemGroup>

<Target Name="_InjectResxAdditionalFiles"
BeforeTargets="PrepareForBuild;CompileDesignTime;GenerateMSBuildEditorConfigFileShouldRun"
DependsOnTargets="PrepareResourceNames">
Expand Down
3 changes: 2 additions & 1 deletion src/ThisAssembly.Tests/ThisAssembly.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5" />
<PackageReference Include="Devlooped.SponsorLink.Build" Version="42.42.213-main" />
<!-- Only needed because we're referencing via P2P and not getting the dependency -->
<PackageReference Include="Devlooped.SponsorLink" Version="0.10.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ThisAssembly/ThisAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NuGetizer" Version="42.42.957-main" />
<PackageReference Include="NuGetizer" Version="42.42.972-main" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
<Compile Remove="..\*.cs" />
</ItemGroup>
Expand Down