Skip to content

Detect metapackage as direct dependency too #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Jul 23, 2024
Merged

Detect metapackage as direct dependency too #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ThisAssembly.AssemblyInfo/ThisAssembly.AssemblyInfo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<IsRoslynComponent>true</IsRoslynComponent>
<!-- This generator supports VB too -->
<PackFolder>analyzers/dotnet/roslyn$(ThisAssemblyMinimumRoslynVersion)</PackFolder>
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -29,6 +28,11 @@ on the `ThisAssembly.Info` class.
</Description>
</PropertyGroup>

<PropertyGroup Label="SponsorLink">
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
<FundingPackageId>ThisAssembly;$(PackageId)</FundingPackageId>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NuGetizer" Version="1.2.2" />

Expand Down
7 changes: 6 additions & 1 deletion src/ThisAssembly.Constants/ThisAssembly.Constants.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<IsRoslynComponent>true</IsRoslynComponent>
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
</PropertyGroup>

<PropertyGroup>
Expand Down Expand Up @@ -38,6 +37,12 @@ C#:
</Description>
</PropertyGroup>

<PropertyGroup Label="SponsorLink">
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
<!-- We also bring in the additional packages that just customize ThisAssembly.Constants -->
<FundingPackageId>ThisAssembly;ThisAssembly.Git;ThisAssembly.Metadata;$(PackageId)</FundingPackageId>
</PropertyGroup>

<ItemGroup>
<None Remove="CSharp.sbntxt" />
<EmbeddedResource Include="CSharp.sbntxt" CopyToOutputDirectory="PreserveNewest" />
Expand Down
6 changes: 5 additions & 1 deletion src/ThisAssembly.Project/ThisAssembly.Project.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<IsRoslynComponent>true</IsRoslynComponent>
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
</PropertyGroup>

<PropertyGroup>
Expand Down Expand Up @@ -38,6 +37,11 @@ C#:
</Description>
</PropertyGroup>

<PropertyGroup Label="SponsorLink">
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
<FundingPackageId>ThisAssembly;$(PackageId)</FundingPackageId>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NuGetizer" Version="1.2.2" />

Expand Down
6 changes: 5 additions & 1 deletion src/ThisAssembly.Resources/ThisAssembly.Resources.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<!-- We cannot use ThisAssembly.Resources as the assembly name, or for whatever
reason, it's never added as an analyzer :/ -->
<AssemblyName>ThisAssembly.Resource</AssemblyName>
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -19,6 +18,11 @@
</Description>
</PropertyGroup>

<PropertyGroup Label="SponsorLink">
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
<FundingPackageId>ThisAssembly;$(PackageId)</FundingPackageId>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NuGetizer" Version="1.2.2" />

Expand Down
6 changes: 5 additions & 1 deletion src/ThisAssembly.Strings/ThisAssembly.Strings.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<IsRoslynComponent>true</IsRoslynComponent>
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -24,6 +23,11 @@ such as "Hello {name}".
</Description>
</PropertyGroup>

<PropertyGroup Label="SponsorLink">
<CustomAfterMicrosoftCSharpTargets>$(MSBuildThisFileDirectory)..\SponsorLink\SponsorLink.Analyzer.targets</CustomAfterMicrosoftCSharpTargets>
<FundingPackageId>ThisAssembly;$(PackageId)</FundingPackageId>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="NuGetizer" Version="1.2.2" />

Expand Down