Packages should not be transitive #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the generated code is typically internal only, it doesn't make a lot of sense to make the packages transitive (via the buildTransitive targets) to referencing projects. The decision on whether a specific project needs its own ThisAssembly or not should be on the consumer. This also removes the error where the referenced project that uses these packages also has an InternalsVisibleTo to the referencing project ,which would then cause an ambiguous reference to ThisAssembly since it lives in two places with the exact same name. Fixes #86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the generated code is typically internal only, it doesn't make a lot of sense to
make the packages transitive (via the buildTransitive targets) to referencing projects.
The decision on whether a specific project needs its own ThisAssembly or not
should be on the consumer.
This also removes the error where the referenced project that uses these packages
also has an InternalsVisibleTo to the referencing project ,which would then cause
an ambiguous reference to ThisAssembly since it lives in two places with the exact
same name.
Fixes #86