Skip to content

Preserve trailing slash in file spec for directory #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2024
Merged

Preserve trailing slash in file spec for directory #125

merged 1 commit into from
Oct 19, 2024

Conversation

kzu
Copy link
Member

@kzu kzu commented Oct 19, 2024

This enhances consistency with the / meaning "start relative path from here on", which can now be used consistently in both the path and url.

@kzu kzu added the enhancement New feature or request label Oct 19, 2024
@kzu kzu force-pushed the dev/trailing-slash branch from ded76db to fa57249 Compare October 19, 2024 02:20
@kzu
Preserve trailing slash in file spec for directory
af111fb 
This enhances consistency with the `/` meaning "start relative path from here on", which can now be used consistently in both the path and url.
@kzu kzu force-pushed the dev/trailing-slash branch from fa57249 to af111fb Compare October 19, 2024 02:22
@devlooped devlooped deleted a comment from devlooped-bot Oct 19, 2024
@devlooped-bot
Copy link
Member

devlooped-bot commented Oct 19, 2024 •
edited
Loading

21 passed 21 passed
21 passed 21 passed
21 passed 21 passed

🧪 Details on macOS Unix 14.7.0

✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/img/icon.png")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "README.md")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: ".", expected: "Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/External/.", expected: "src/External/Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/External/.", expected: "src/External/.")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./", expected: ".editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./src/", expected: "src/.editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "docs/", expected: "docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "./", expected: "src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "external/docs/", expected: "external/docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "./common/", expected: "common/src/docs")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "external/", expected: "external/src")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "./external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/src/", expected: "docs/src/README.md")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsFinalDoesNotReplaceDot
✅ Devlooped.FileSpecTests.WhenSourceUriEndsInSlathThenTargetPathIsBaseDir
✅ Devlooped.FileSpecTests.WhenSpecAndSourceUriEndInSlathThenPreservesBaseDirSlash

🧪 Details on Ubuntu 22.04.5 LTS

✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/img/icon.png")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "README.md")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: ".", expected: "Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/External/.", expected: "src/External/Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/External/.", expected: "src/External/.")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./", expected: ".editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./src/", expected: "src/.editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "docs/", expected: "docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "./", expected: "src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "external/docs/", expected: "external/docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "./common/", expected: "common/src/docs")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "external/", expected: "external/src")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "./external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/src/", expected: "docs/src/README.md")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsFinalDoesNotReplaceDot
✅ Devlooped.FileSpecTests.WhenSourceUriEndsInSlathThenTargetPathIsBaseDir
✅ Devlooped.FileSpecTests.WhenSpecAndSourceUriEndInSlathThenPreservesBaseDirSlash

🧪 Details on Microsoft Windows 10.0.20348

✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "src/Directory.props")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/img/icon.png")
✅ Devlooped.FileSpecTests.CalculateDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "README.md")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: ".", expected: "Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "src/External/.", expected: "src/External/Foo.cs")
✅ Devlooped.FileSpecTests.WhenPathHasDot(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "src/External/.", expected: "src/External/.")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./", expected: ".editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "./src/", expected: "src/.editorconfig")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/blob/main"···, path: "docs/", expected: "docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "./", expected: "src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/raw/main/"···, path: "external/docs/", expected: "external/docs/src/Directory.props")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "./common/", expected: "common/src/docs")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://github.com/devlooped/dotnet-file/tree/main"···, path: "external/", expected: "external/src")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "./external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "docs/src/", expected: "docs/src/README.md")
✅ Devlooped.FileSpecTests.WhenPathIsDirAppendsDefaultPath(url: "https://raw.githubusercontent.com/kzu/dotnet-file/"···, path: "external/", expected: "external/docs/img/icon.png")
✅ Devlooped.FileSpecTests.WhenPathIsFinalDoesNotReplaceDot
✅ Devlooped.FileSpecTests.WhenSourceUriEndsInSlathThenTargetPathIsBaseDir
✅ Devlooped.FileSpecTests.WhenSpecAndSourceUriEndInSlathThenPreservesBaseDirSlash

from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜

@kzu kzu merged commit 063b3a3 into main Oct 19, 2024
11 checks passed
@kzu kzu deleted the dev/trailing-slash branch October 19, 2024 02:30
@devlooped devlooped locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzu @devlooped-bot