Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to update VS 2022 (Current channel) installations #123

Closed
gusper opened this issue Nov 30, 2021 · 1 comment
Closed

Failing to update VS 2022 (Current channel) installations #123

gusper opened this issue Nov 30, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@gusper
Copy link

gusper commented Nov 30, 2021 •
edited by devlooped-bot
Loading

Describe the Bug

I'm trying to update the currently installed "Current" instance of Visual Studio 2022 (Dev17). It fails though and I can see it's trying to run the Dev16 bootstrapper instead. Looks like the "Release" channel is hardcoded to always point to the 16 bootstrapper, but I haven't looked at the code enough to know if that's the issue.

Steps to Reproduce

  • Install VS 2022 from Current channel
  • Run dotnet-vs from elevated command prompt: vs update and then select the Current channel instance

Expected Behavior

I'd expect it to run the v17 bootstrapper.

Output

vs update ?
Multiple instances found. Select the one to run:
1: Visual Studio Enterprise 2022 - Version 17.1.0 Preview 2.0 [31929.402.main]
2: Visual Studio Enterprise 2022 - Version 17.0.1
3: Visual Studio Enterprise 2022 - Version 17.1.0 Preview 1.1
You can also run [a|all] or skip one instance with !x
2
Downloading https://aka.ms/vs/16/release/vs_enterprise.exe...
The SSL connection could not be established, see inner exception.

Version Info

dotnet-vs 1.1.1

Back this issue
Back this issue
@gusper gusper added the bug Something isn't working label Nov 30, 2021
kzu added a commit that referenced this issue Aug 18, 2022
@kzu
Improve handling of update/modify scenarios
2e1e41d 
We previously hardcoded the major VS version used to build the channel bootstrapper, but this was only necessary for Install scenarios, where we don't know already the channel/installation we're dealing with.

So for update/modify, we pass down the selected instance (or default selected) major version, so we don't select the wrong major version inadvertently.

In addition, for Install, we have a smarter heuristics now that will attempt to load the latest release bootstrapper major version from the official docs on CLI installs for VS, and defaulting to hardcoded "17" for now in the unlikely scenario where we can't reach the page for some reason.

Fixes #123
kzu added a commit that referenced this issue Aug 18, 2022
@kzu
Improve handling of update/modify scenarios
1e50d94 
We previously hardcoded the major VS version used to build the channel bootstrapper, but this was only necessary for Install scenarios, where we don't know already the channel/installation we're dealing with.

So for update/modify, we pass down the selected instance (or default selected) major version, so we don't select the wrong major version inadvertently.

In addition, for Install, we have a smarter heuristics now that will attempt to load the latest release bootstrapper major version from the official docs on CLI installs for VS, and defaulting to hardcoded "17" for now in the unlikely scenario where we can't reach the page for some reason.

Fixes #123
kzu added a commit that referenced this issue Aug 18, 2022
@kzu
Improve handling of update/modify scenarios
83d7ec8 
We previously hardcoded the major VS version used to build the channel bootstrapper, but this was only necessary for Install scenarios, where we don't know already the channel/installation we're dealing with.

So for update/modify, we pass down the selected instance (or default selected) major version, so we don't select the wrong major version inadvertently.

In addition, for Install, we have a smarter heuristics now that will attempt to load the latest release bootstrapper major version from the official docs on CLI installs for VS, and defaulting to hardcoded "17" for now in the unlikely scenario where we can't reach the page for some reason.

Fixes #123
@kzu kzu closed this as completed in 3aa6458 Aug 18, 2022
@kzu
Copy link
Member

kzu commented Aug 18, 2022

Thanks for reporting the issue! A fix has been merged and published. Please update to the latest nuget package and let us know how it works for you.

Thanks :)

PS: sorry for taking so long :(.

@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kzu @gusper