Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #32

Closed
pulimento opened this issue May 12, 2020 · 2 comments
Closed

Some suggestions #32

pulimento opened this issue May 12, 2020 · 2 comments

Comments

@pulimento
Copy link

pulimento commented May 12, 2020

Hi,

Your tool seems to run just fine. I have some recommendations, though:

  • There isn't a feature that lets you specify individual workloads at install time. E.g. tried to install the Android SDK, and the way I found to automate that is to add at the end the '--includeRecommended' modifier, which is passed directly to the installer. But it install more components that I want. Perhaps you can add a switch to specify an exact component from the list
  • If I'm not mistaken, this requires .net core 3.1 runtime installed on the machine. Perhaps would be interesting to lower this requirement (if possible), in a hope to have some spare 2.x version already installed
  • Without parameters, this add a "Com" alias to my VS Community install. It doesn't harm me to have it, but it seems a bit unnecesary for me

Anyway, thanks for your work

Back this issue
Back this issue

kzu added a commit that referenced this issue Jun 11, 2020
We don't really use (yet?) any 3.1-specific feature, so
let's lower the requirements instead.

Fix #36, related to #32
@kzu
Copy link
Member

kzu commented Jun 11, 2020

Hi there!

  1. The tool actually passes down to the installer all the supported switches in that list, so you can use them directly as documented in the list you linked to
  2. Yes, makes sense. Fixed in the linked PR.
  3. Do you have no other installs at all in the default target folder at %ProgramFiles(x86)%\Microsoft Visual Studio\2019? That's the reason we add a nickname, since otherwise you get a generated one by VS which is even worse :) https://github.com/kzu/dotnet-vs/blob/master/VisualStudio/Commands/InstallCommand.cs#L33-L44

kzu added a commit that referenced this issue Jun 11, 2020
We don't really use (yet?) any 3.1-specific feature, so
let's lower the requirements instead.

Fix #36, related to #32
@kzu
Copy link
Member

kzu commented Aug 21, 2020

Haven't heard back in a while, so I'm tentatively closing this. Please do reopen if you have further questions!

Thanks

@kzu kzu closed this as completed Aug 21, 2020
@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants